Enable ovn-cms-options in all ovn environment files

[venkata anil]

This option must be enabled in all controllers to be selected for hosting
gateway router. Background information about this option -

Admin sets ovn-cms-options in external_ids as

ovs-vsctl set open .
   external_ids:ovn-cms-options="enable-chassis-as-gw"

to enable a chassis as a candidate for scheduling gateway router.
Networking-ovn will parse ovn-cms-options and select this chassis
if it has proper bridge mappings.

This helps admin to exclude compute nodes to host gateway routers as
they are more likely to be restarted for maintenance operations.

This option must be enabled in all controllers to be selected for hosting
gateway router.

Currently it is enabled in

https://github.com/openstack/tripleo-heat-templates/tree/master/environments/services
neutron-ovn-ha.yaml
neutron-ovn-hw-offload.yaml
neutron-ovn.yaml

but missing in
neutron-ovn-dvr-ha.yaml
neutron-ovn-dvr.yaml

So when these environment files are used for deployment, controller is missing this option and vms are unable to reach external connectivity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563503

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563503
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=39ef030553e65ed80326afcf339029ed0f2ae8e4
Submitter: Zuul
Branch: master

commit 39ef030553e65ed80326afcf339029ed0f2ae8e4
Author: venkata anil <email address hidden>
Date: Mon Apr 23 13:00:35 2018 +0530

    Add OVNCMSOptions in dvr environment files

    This option must be enabled in a controller to be selected for hosting
    a gateway router. But it is missing in DVR environment files. So when
    these files are used for the deployment, vms were not able to reach
    external network. So adding this option for DVR files.

    Change-Id: Ibfc9baf3aca55b49cc197758cbf5a0df9daa8b9b
    Closes-Bug: 1766183

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564720

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564720
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=052b3330a07a6b5c35ec2b8d9488e74270e3a41b
Submitter: Zuul
Branch: stable/queens

commit 052b3330a07a6b5c35ec2b8d9488e74270e3a41b
Author: venkata anil <email address hidden>
Date: Mon Apr 23 13:00:35 2018 +0530

    Add OVNCMSOptions in dvr environment files

    This option must be enabled in a controller to be selected for hosting
    a gateway router. But it is missing in DVR environment files. So when
    these files are used for the deployment, vms were not able to reach
    external network. So adding this option for DVR files.

    Change-Id: Ibfc9baf3aca55b49cc197758cbf5a0df9daa8b9b
    Closes-Bug: 1766183
    (cherry picked from commit 39ef030553e65ed80326afcf339029ed0f2ae8e4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.

[Luis Arizmendi (luisjariz)]

As far as I understand, that option was not setup in those files (neutron-ovn-dvr-ha.yaml and neutron-ovn-dvr.yaml ) intentionally since are intended to deploy a DVR architecture, not a centralized one [1].

[1] https://docs.openstack.org/networking-ovn/latest/admin/refarch/refarch.html#centralized-floating-ips