FFU: post upgrade openstack-nova-consoleauth service is not disabled

[Marius Cornea]

Description of problem:
FFU: post upgrade openstack-nova-consoleauth service is not disabled:

[root@controller-0 heat-admin]# systemctl status openstack-nova-consoleauth
● openstack-nova-consoleauth.service - OpenStack Nova VNC console auth Server
   Loaded: loaded (/usr/lib/systemd/system/openstack-nova-consoleauth.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Fri 2018-04-20 23:48:41 UTC; 17h ago
 Main PID: 2192 (code=exited, status=0/SUCCESS)

Apr 20 19:15:42 controller-0 systemd[1]: Starting OpenStack Nova VNC console auth Server...
Apr 20 19:15:57 controller-0 nova-consoleauth[2192]: Option "rpc_backend" from group "DEFAULT" is deprecated for removal. Its value may be silently ignored in the future.
Apr 20 19:15:57 controller-0 systemd[1]: Started OpenStack Nova VNC console auth Server.
Apr 20 23:48:27 controller-0 systemd[1]: Stopping OpenStack Nova VNC console auth Server...
Apr 20 23:48:41 controller-0 systemd[1]: Stopped OpenStack Nova VNC console auth Server.

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-8.0.2-0.20180416194360.29a5ad5.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy Newton
2. Upgrade to Queens via the fast forward upgrade procedure
3. On controller nodes check openstack-nova-consoleauth service status:
systemctl status openstack-nova-consoleauth

Actual results:
Service is not disabled:
● openstack-nova-consoleauth.service - OpenStack Nova VNC console auth Server
   Loaded: loaded (/usr/lib/systemd/system/openstack-nova-consoleauth.service; enabled; vendor preset: disabled)

Expected results:
Service is disabled:
● openstack-nova-consoleauth.service - OpenStack Nova VNC console auth Server
   Loaded: loaded (/usr/lib/systemd/system/openstack-nova-consoleauth.service; disabled; vendor preset: disabled)

Additional info:

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563432

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563432
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b1d0ed091076f33bec7cbbeb32dbe27fcda417db
Submitter: Zuul
Branch: master

commit b1d0ed091076f33bec7cbbeb32dbe27fcda417db
Author: Marius Cornea <email address hidden>
Date: Sat Apr 21 13:55:36 2018 -0400

    Fix openstack-nova-consoleauth service upgrade check

    When running the FFU workflow the openstack-nova-consoleauth
    service gets stopped before running the upgrade tasks so the
    task for disabling the service is ignored. This change fixes
    the nova_consoleauth_enabled command to check if the service
    is enabled instead of active.

    Change-Id: If1e0f43c1962496b68c1c982db86a6dec58e05c5
    Closes-bug: 1765997

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563669
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3101ee1895a019b5339fcaa2ede957db3b5f5550
Submitter: Zuul
Branch: stable/queens

commit 3101ee1895a019b5339fcaa2ede957db3b5f5550
Author: Marius Cornea <email address hidden>
Date: Sat Apr 21 13:55:36 2018 -0400

    Fix openstack-nova-consoleauth service upgrade check

    When running the FFU workflow the openstack-nova-consoleauth
    service gets stopped before running the upgrade tasks so the
    task for disabling the service is ignored. This change fixes
    the nova_consoleauth_enabled command to check if the service
    is enabled instead of active.

    Change-Id: If1e0f43c1962496b68c1c982db86a6dec58e05c5
    Closes-bug: 1765997
    (cherry picked from commit b1d0ed091076f33bec7cbbeb32dbe27fcda417db)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.