Crash when printing simultaneously

[Aleksandr Sh]

Steps to reproduce:
1. Open pcbnew
2. File -> Print...
3. Select all layers
4. Press print, select a printer and print somewhere
5. Before printing dialog hides, repeat step 4
6. Kicad will crash

Tested only in pcbnew, may be reproducible in other applications.

Application: kicad
Version: (5.0.0-rc2-dev-446-gb46fc7fe9), debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.3 libidn2/2.0.4 nghttp2/1.31.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.66.0
    Curl: 7.59.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision cfa99168369b881e3a0a024decfc8896bae86745
https://git.launchpad.net/kicad/patch/?id=cfa99168369b881e3a0a024decfc8896bae86745

[Aleksandr Sh (dsa-t)]

Print button becomes active if the printing dialog is reopened, allowing to crash KiCad.

Application: kicad
Version: (5.0.0-rc2-dev-499-gcfa991683-dirty), debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.3 libidn2/2.0.4 nghttp2/1.31.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.66.0
    Curl: 7.59.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Aleksandr Sh (dsa-t)]

This still happens.

1. Open some complex board.
2. In printing dialog, select all layers
3. Print to PDF using "Microsoft Print to PDF" or something so it takes a long time to process
4. While it prints, reopen print dialog and print to PDF again

While both are printing, Pcbnew will crash.

The problem with the fix is that the button is still active after reopening the dialog.

Application: kicad
Version: (6.0.0-rc1-dev-1583-gb0ab53ac2), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

While this doesn't reproduce on OSX, I've added some code that I hope will prevent it on MSW.

[KiCad Janitor (kicad-janitor)]

Fixed in revision c2d77a73007b61ae8a6aaf41aefadec988ae27c3
https://git.launchpad.net/kicad/patch/?id=c2d77a73007b61ae8a6aaf41aefadec988ae27c3