EESchema: Edit Symbol Library References not working for power symbols

[Tobias Rohde]

In EESchema the new "Edit Symbol library references" function seems not to work correctly with old rescued power symbols like "-VAA" or "VAA".

a) The generated netlist becomes updated with the new power symbol (e.g. "power:-6V") but the symbol in the schematic stays as before the update (-VAA).

Tested on MAC OSX with 5.0.0-rc2-491-g4302394 build.

[Jeff Young (jeyjey)]

And since we don't let you edit the Value field of power symbols, there's no workaround.

[Jeff Young (jeyjey)]

@Tobias, does it not update once you OK out of the dialog? There's code in there to set the Value field to the symbol name if it's a power symbol, but it only runs when exiting the dialog.

If that's not working, then two things to check: if Kicad thinks it's a power symbol, then the value textbox in the right-hand column of the Edit Symbol dialog will be read-only when the Value field is selected in the middle column.

After changing the library reference, OK out of the dialog and go back in. Has the Value field been updated?

[Jeff Young (jeyjey)]

Ahhh... I'll bet the old rescued symbol doesn't have the power: prefix, so Kicad doesn't do the automatic update.

(I've changed the logic to check whether the /new/ symbol is a power symbol, rather than checking the /old/ symbol.)

[Jeff Young (jeyjey)]

Is the janitor down?

[Nick Østergaard (nickoe)]

@Jeff, in what comnit do you think thus is fixed? I coukd not see anything recent that looks related to this.

[Jeff Young (jeyjey)]

Commit: 4b3772cf07e13fd6ea79292c05d03c85f89b8958

(Did it not make it into origin/master?)

[Nick Østergaard (nickoe)]

Maybe you didn't put it at the time, but it looks like https://bugs.launchpad.net/kicad/+bug/1762043 was serviced by the janitor so it looks like it is running fine.

[Maciej Suminski (orsonmmz)]

It is a bit surprising, but apparently Janitor has hiccups from time to time. In the logs I see it is processing all commits, but for some reason it does not always detect 'Fixes' line, even though in a dry run it recognizes them correctly.