Adjust non-puppetish (ansible/external deploys) detection logic for YAML validate hiera interpolation

[Bogdan Dobrelya]

See https://review.openstack.org/#/c/562809/
We need to come up with something better than just "if 'ansible' in f " to exclude ansible/external deployments from the hiera interpolation checks.

So the given example:

  container_registry_host:
    str_replace:
      template:
        "{{ hostvars.raw_get(groups['docker_registry'][0])['$REGISTRY_ip'] }}"
      params:
        $REGISTRY: {get_param: [ServiceNetMap, DockerRegistryNetwork]}

shall work for non-puppet based deployments in the end.

[Bogdan Dobrelya (bogdando)]

At the first glance, we could additionally verify if there is no external_deploy_tasks defined?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/562996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562996
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=68c60892a1df78d2cd13ff5789cce3aef104cb66
Submitter: Zuul
Branch: master

commit 68c60892a1df78d2cd13ff5789cce3aef104cb66
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Apr 20 11:11:19 2018 +0200

    Omit hiera YAML validations for external deploys

    Closes-bug: #1765641

    Change-Id: I3e98521f6396acc9e4e1a7b32faec85e988ab0fe
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.