55-heat-config isn't present when upgrading to a containerized undercloud

[Emilien Macchi]

When upgrading the undercloud from Queens (non containerized) to Rocky (containerized, it failed to run deployment ansible tasks because /usr/libexec/os-refresh-config/configure.d/55-heat-config isn't deployed.

How to reproduce?

Deploy an undercloud on Queens
Follow the doc to upgrade the undercloud (openstack undercloud upgrade --use-heat)

Results:
Ansible complains about missing /usr/libexec/os-refresh-config/configure.d/55-heat-config script for this task: https://git.openstack.org/cgit/openstack/tripleo-common/tree/tripleo_common/templates/deployments.yaml#n38

[Emilien Macchi (emilienm)]

Some logs: http://logs.openstack.org/33/553633/52/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/3f56d7b/logs/undercloud/home/zuul/undercloud_upgrade.log.txt.gz#_2018-04-20_00_47_22

[Bogdan Dobrelya (bogdando)]

The file comes from python-heat-agent and it had been installed undercloud http://logs.openstack.org/33/553633/52/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/3f56d7b/logs/undercloud/home/zuul/install_packages.sh.log.txt.gz . Looks weird.

[Bogdan Dobrelya (bogdando)]

rpm -V python-heat-agent shows the file is missing, indeed. So we need to figure out why.

[James Slagle (james-slagle)]

it's because of this code from instack-undercloud:

https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L1752

You'll need to do something such as a "yum reinstall python-heat-agent" to get the file back.

[Emilien Macchi (emilienm)]

Thanks James, indeed, Brad wrote this code back in 2016!

https://bugs.launchpad.net/tripleo/+bug/1533230

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563133

[Emilien Macchi (emilienm)]

Fixed by https://review.rdoproject.org/r/#/c/13477/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/563133