Initialize rabbitmq_use_ssl in ConfigClientOptions::ConfigClientOptions()

[Ananth Suryanarayana]

This bool rabbitmq_use_ssl has been left uninitialized in the constructor, and potentially can cause some unit tests to become flaky.

diff --git a/config-client-mgr/config_client_options.h b/config-client-mgr/config_client_options.h
index 525efba..cebf8f6 100644
--- a/config-client-mgr/config_client_options.h
+++ b/config-client-mgr/config_client_options.h
@@ -10,32 +10,42 @@

 struct ConfigClientOptions {
     ConfigClientOptions() :
- stale_entries_cleanup_timeout(0), end_of_rib_timeout(0),
- peer_response_wait_time(0) {
+ stale_entries_cleanup_timeout(0),
+ end_of_rib_timeout(0),
+ peer_response_wait_time(0),
+ rabbitmq_use_ssl(false) {
     }
+
     ConfigClientOptions(const std::string &in_server,
             const std::string &in_password, const std::string &in_user,
             const std::string &in_certs_store, int in_sect_time,
             int in_eort_time, int in_prwt_time)
- : server_url(in_server), password(in_password), user(in_user),
+ : server_url(in_server),
+ password(in_password), user(in_user),
           certs_store(in_certs_store),
           stale_entries_cleanup_timeout(in_sect_time),
           end_of_rib_timeout(in_eort_time),
- peer_response_wait_time(in_prwt_time) {
+ peer_response_wait_time(in_prwt_time),
+ rabbitmq_use_ssl(false) {
     }
+
     ConfigClientOptions(const std::string &in_server,
             const std::string &in_password, const std::string &in_user,
             const std::string &in_certs_store, int in_sect_time,
             int in_eort_time, int in_prwt_time,
             const std::string &cfg_db_user, const std::string &cfg_db_password,
             std::vector<std::string> &cfg_db_server_list)
- : server_url(in_server), password(in_password), user(in_user),
+ : server_url(in_server),
+ password(in_password),
+ user(in_user),
           certs_store(in_certs_store),
           stale_entries_cleanup_timeout(in_sect_time),
           end_of_rib_timeout(in_eort_time),
           peer_response_wait_time(in_prwt_time),
- config_db_username(cfg_db_user), config_db_password(cfg_db_password),
- config_db_server_list(cfg_db_server_list) {
+ config_db_username(cfg_db_user),
+ config_db_password(cfg_db_password),
+ config_db_server_list(cfg_db_server_list),
+ rabbitmq_use_ssl(false) {
     }

     std::string server_url;

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/42192
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/42193
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/42192
Committed: http://github.com/Juniper/contrail-common/commit/8eb9e0b382faee56fb9b1e27c1c97952ce6367fa
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8eb9e0b382faee56fb9b1e27c1c97952ce6367fa
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Apr 19 09:49:26 2018 -0700

Initialize rabbitmq_use_ssl in ConfigClientOptions::ConfigClientOptions

This bool rabbitmq_use_ssl has been left uninitialized in the
constructor, and potentially can cause some unit tests to become
flaky.

Change-Id: I68d4c539d6cde6499277e94e92865ab5fb7e408a
Closes-Bug: 1765464

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/42193
Committed: http://github.com/Juniper/contrail-common/commit/22bb0ae2d13dcc4b6e8d3769b654ba587e64089e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 22bb0ae2d13dcc4b6e8d3769b654ba587e64089e
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Apr 19 09:49:26 2018 -0700

Initialize rabbitmq_use_ssl in ConfigClientOptions::ConfigClientOptions

This bool rabbitmq_use_ssl has been left uninitialized in the
constructor, and potentially can cause some unit tests to become
flaky.

Change-Id: I68d4c539d6cde6499277e94e92865ab5fb7e408a
Closes-Bug: 1765464