live_migration_inbound_addr cannot be used with other uri parameters

[Oliver Walsh]

In manifests/migration/libvirt.pp, live_migration_scheme is being used in place of live_migration_uri when live_migration_inbound_addr is set and the transport is TLS.

This prohibits a non-default port/user/extra_params being used which is often required to fully describe the uri, particularly for the ssh transport (see https://bugs.launchpad.net/nova/+bug/1671288).

However live_migration_inbound_addr also works with live_migration_uri so there is no compelling reason to do this. For now we should revert back to using live_migration_uri in all cases.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/562764

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562764
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=d7b85da651b6144cbc3ea4fd522f190020b39896
Submitter: Zuul
Branch: master

commit d7b85da651b6144cbc3ea4fd522f190020b39896
Author: Oliver Walsh <email address hidden>
Date: Thu Apr 19 17:12:15 2018 +0100

    Allow live_migration_inbound_addr to be used with non-default port/user/extra_params

    live_migration_scheme was being used when live_migration_inbound_addr was set.
    This prohibits a non-default port/user/extra_params being used, which is often
    required to fully describe the uri, particularly for the ssh transport
    (see bug#1671288).

    However live_migration_inbound_addr also works with live_migration_uri, so for
    now revert back to using live_migration_uri in all cases.

    Change-Id: Ifdc5fbd05195604ab6ea6564d0905f9385c6df67
    Closes-Bug: #1765462

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/567548

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567548
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=b308caef345db4164ea84bf1a738325ecdba540e
Submitter: Zuul
Branch: stable/queens

commit b308caef345db4164ea84bf1a738325ecdba540e
Author: Oliver Walsh <email address hidden>
Date: Thu Apr 19 17:12:15 2018 +0100

    Allow live_migration_inbound_addr to be used with non-default port/user/extra_params

    live_migration_scheme was being used when live_migration_inbound_addr was set.
    This prohibits a non-default port/user/extra_params being used, which is often
    required to fully describe the uri, particularly for the ssh transport
    (see bug#1671288).

    However live_migration_inbound_addr also works with live_migration_uri, so for
    now revert back to using live_migration_uri in all cases.

    Change-Id: Ifdc5fbd05195604ab6ea6564d0905f9385c6df67
    Closes-Bug: #1765462
    (cherry picked from commit d7b85da651b6144cbc3ea4fd522f190020b39896)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/567831

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567831
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=a8b7530e0297d1bc98cfd1d1989efcad8b6499b1
Submitter: Zuul
Branch: stable/pike

commit a8b7530e0297d1bc98cfd1d1989efcad8b6499b1
Author: Oliver Walsh <email address hidden>
Date: Thu Apr 19 17:12:15 2018 +0100

    Allow live_migration_inbound_addr to be used with non-default port/user/extra_params

    live_migration_scheme was being used when live_migration_inbound_addr was set.
    This prohibits a non-default port/user/extra_params being used, which is often
    required to fully describe the uri, particularly for the ssh transport
    (see bug#1671288).

    However live_migration_inbound_addr also works with live_migration_uri, so for
    now revert back to using live_migration_uri in all cases.

    Change-Id: Ifdc5fbd05195604ab6ea6564d0905f9385c6df67
    Closes-Bug: #1765462
    (cherry picked from commit d7b85da651b6144cbc3ea4fd522f190020b39896)
    (cherry picked from commit b308caef345db4164ea84bf1a738325ecdba540e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 13.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 11.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 12.5.0 release.