webstaff MARC editor can spam requests for fixed field metadata

[Galen Charlton]

The web staff MARC editor can issue repeated (and redundant) calls of open-ils.cat.biblio.fixed_field_values.by_rec_type and open-ils.fielder.cmfpm.atomic when initializing itself.

In particular, each eg-marc-edit-fixed-field directive invokes the tag table service to fetch fixed field position and value data. While the results are cached in Hatch, if the results are not /already/ cached, currently each eg-marc-edit-fixed-field directive (of which there are 64) invokes the service. Most of them get a cache miss and consequently make the API calls.

This has been observed to make open-ils.cat services in particular hit configured drone limits.

Evergreen 3.0 and master

[Galen Charlton (gmc)]

A patch is available in the user/gmcharlt/lp1765444_marc_editor_ff_init branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1765444_marc_editor_ff_init

[Mike Rylander (mrylander)]

WORKSFORME. Thanks, Galen. Signoff branch at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1765444_marc_editor_ff_init-signoff

[Cesar V (cesardv)]

Same for me. Here's another signoff branch...

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/gmcharlt_lp1765444_marc_editor_ff_init-signoff

[Jeff Davis (jdavis-sitka)]

We've applied this in our production 3.1 environment. Prior to the fix, we were seeing big spikes in open-ils.cat drone counts; that problem seems to have gone away once the fix was in place.

[Mike Rylander (mrylander)]

Merged to master through 3.0. Thanks, Galen, Cesar, and Jeff!