Juniper Openstack

'revert' security draft action is not accurate

Bug #1765217 reported by Édouard Thuleau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
High
Édouard Thuleau
Juniper Openstack r5.0.0
Trunk
Fix Committed
High
Édouard Thuleau
Juniper Openstack r5.1.0

Bug Description

In security draft mode, the security admin can commit or discard any pending security modifications after he reviewed them. He can do that through a new API POST call where he should specify action between two values 'commit' or 'revert'. But 'revert' is not appropriated here, 'discard' seems more accurate.

Édouard Thuleau (ethuleau)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42118
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42119
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42120
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42121
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42118
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42120
Committed: http://github.com/Juniper/contrail-api-client/commit/b1405765076d02d6945da39e9313e5fbf74b7454
Submitter: Rudra Rugge (<email address hidden>)
Branch: R5.0

commit b1405765076d02d6945da39e9313e5fbf74b7454
Author: Édouard Thuleau <email address hidden>
Date: Wed Apr 18 23:51:52 2018 +0200

[api-lib] Rename security draft action 'revert' to 'discard'

When security admin does not want to enforce proposed security
modification, it's more accurate to use term 'discard' than 'revert' to
discard all that modifications.

Change-Id: I06e803dc7c859b6e9194c020a8dbfbc88ab12c4d
Closes-Bug: #1765217

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42121
Committed: http://github.com/Juniper/contrail-controller/commit/6f5b5c8d017c5e84ec606c0c77765da53cfbacb8
Submitter: Rudra Rugge (<email address hidden>)
Branch: R5.0

commit 6f5b5c8d017c5e84ec606c0c77765da53cfbacb8
Author: Édouard Thuleau <email address hidden>
Date: Wed Apr 18 23:54:56 2018 +0200

[config] Rename security draft action 'revert' to 'discard'

When security admin does not want to enforce proposed security
modification, it's more accurate to use term 'discard' than 'revert' to
discard all that modifications.

Change-Id: I7f51425e3a8aa4b682268513b9939df0390908d6
Depends-On: I06e803dc7c859b6e9194c020a8dbfbc88ab12c4d
Closes-Bug: #1765217

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42119
Committed: http://github.com/Juniper/contrail-api-client/commit/1383c8226628347a1193541ed59d3a6f58a54307
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit 1383c8226628347a1193541ed59d3a6f58a54307
Author: Édouard Thuleau <email address hidden>
Date: Wed Apr 18 23:51:52 2018 +0200

[api-lib] Rename security draft action 'revert' to 'discard'

When security admin does not want to enforce proposed security
modification, it's more accurate to use term 'discard' than 'revert' to
discard all that modifications.

Change-Id: I06e803dc7c859b6e9194c020a8dbfbc88ab12c4d
Closes-Bug: #1765217

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42118
Committed: http://github.com/Juniper/contrail-controller/commit/66db52fcc89a906d35b17e86a2ce1b08f73431ee
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 66db52fcc89a906d35b17e86a2ce1b08f73431ee
Author: Édouard Thuleau <email address hidden>
Date: Wed Apr 18 23:54:56 2018 +0200

[config] Rename security draft action 'revert' to 'discard'

When security admin does not want to enforce proposed security
modification, it's more accurate to use term 'discard' than 'revert' to
discard all that modifications.

Change-Id: I7f51425e3a8aa4b682268513b9939df0390908d6
Depends-On: I06e803dc7c859b6e9194c020a8dbfbc88ab12c4d
Closes-Bug: #1765217

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.