Some resourcemanagers are not using the base underscore methods

Bug #1765087 reported by Adriano Petrich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Low
Eyal B

Bug Description

Some ResourceManagers not using the standard underscore
methods defined in the base class. Those underscore methods have the
appropriate try catch to parse the unfriendly keystoneauth errors into
more cli friendly errors.

they can be seen here

$ grep _raise_api_exceptio mistralclient/ -rs
mistralclient/api/v2/actions.py: self._raise_api_exception(resp)
mistralclient/api/v2/actions.py: self._raise_api_exception(resp)
mistralclient/api/v2/actions.py: self._raise_api_exception(resp)
mistralclient/api/v2/workbooks.py: self._raise_api_exception(resp)
mistralclient/api/v2/workbooks.py: self._raise_api_exception(resp)
mistralclient/api/v2/workbooks.py: self._raise_api_exception(resp)
mistralclient/api/v2/workflows.py: self._raise_api_exception(resp)
mistralclient/api/v2/workflows.py: self._raise_api_exception(resp)
mistralclient/api/v2/workflows.py: self._raise_api_exception(resp)

at this moment the base.ResouceManager._<methods> need to be changed so all subclassed resmanagers can use the standard calls. That include better support to returning lists

Tags: tech-debt
Changed in mistral:
status: New → Triaged
importance: Undecided → Low
Dougal Matthews (d0ugal)
tags: added: tech-debt
Changed in mistral:
assignee: nobody → Eyal B (eyalb1)
milestone: none → train-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-mistralclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/673493

Changed in mistral:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-mistralclient (master)

Reviewed: https://review.opendev.org/673493
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=051e9fa22b1b17d8c0405d940c7f7c593fcff28d
Submitter: Zuul
Branch: master

commit 051e9fa22b1b17d8c0405d940c7f7c593fcff28d
Author: Eyal <email address hidden>
Date: Tue Jul 30 15:15:16 2019 +0300

    Some resource managers are not using the base underscore methods

    Refactor the base class so they can use these methods

    Change-Id: I8455772eee4865d535b3002e2d922149fb8f8a6e
    Closes-bug: #1765087

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-mistralclient 3.10.0

This issue was fixed in the openstack/python-mistralclient 3.10.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.