Fix some errors in ODL update tasks

[Janki Chhatbar]

Fix some indentation issues, assign correct ownership to config file and delete "data" folder for ODL update and upgrade.

The owner and group for ODL config file comes from kolla and is mounted into the container upon restart.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/561445
Reason: TO NOT RE-CHECK OR RE-APPROVE - CLEARING THE GATE NOW TO FIX A BLOCKER

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561445
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=871e9619d5fdfa201736a2c6f0bafb5a4c56d89d
Submitter: Zuul
Branch: master

commit 871e9619d5fdfa201736a2c6f0bafb5a4c56d89d
Author: Janki Chhatbar <email address hidden>
Date: Sun Apr 15 14:45:27 2018 +0800

    Correct indentation and file path

    Indentation for few lines is corrected and
    correct path for config file is updated. data
    folder is deleted during update/upgrade. Set
    correct permissions (42462:42462) for
    genius-mdsalutil-config.xml. 42462 comes from
    kolla and is id for odl user inside the container.

    Closes-Bug: 1764603
    Change-Id: Ie343cd4cab7cc009b1940a98fa73b1ac15b3b56d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/562524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562524
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=eec1d48d68f2c9cf3166042c9eb90c0b471fde2d
Submitter: Zuul
Branch: stable/queens

commit eec1d48d68f2c9cf3166042c9eb90c0b471fde2d
Author: Janki Chhatbar <email address hidden>
Date: Sun Apr 15 14:45:27 2018 +0800

    Correct indentation and file path

    Indentation for few lines is corrected and
    correct path for config file is updated. data
    folder is deleted during update/upgrade. Set
    correct permissions (42462:42462) for
    genius-mdsalutil-config.xml. 42462 comes from
    kolla and is id for odl user inside the container.

    Closes-Bug: 1764603
    Change-Id: Ie343cd4cab7cc009b1940a98fa73b1ac15b3b56d
    (cherry picked from commit 871e9619d5fdfa201736a2c6f0bafb5a4c56d89d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.