Tripleo-upgrade role is not complying with lint specifications

[Gabriele Cerami]

Gate jobs are failing because of not compliance of the tripleo-upgrade role with ansible specifications, as seen in

http://logs.openstack.org/60/534960/2/gate/openstack-tox-linters/88890c4/job-output.txt.gz#_2018-04-16_11_31_46_586956

Specifically all the tasks that fail following a condition, should have a name too

[Alex Schultz (alex-schultz)]

Actually it looks like the linter is checking the tripleo-upgrade role on changes for oooq-extras

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

We should sync the tox linters check in tripleo-upgrade with the one tripleo-quickstart-extras so that this don't happen anymore.

[Emilien Macchi (emilienm)]

Reducing to high as it doesn't affect all tripleo jobs and all projects.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/561678

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/561679

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561678
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=2bead7f8be288c1e3ad67026e4576108e5696d03
Submitter: Zuul
Branch: master

commit 2bead7f8be288c1e3ad67026e4576108e5696d03
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Apr 16 18:41:06 2018 +0200

    Adhere to ANSIBLE0011 All tasks should be named.

    Change-Id: Idfe041fba9120964a5af06b3a25c55b87b611960
    Closes-Bug: #1764454

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561679
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=3693144631a4a29f252ec2e4a82ebc6ad3c2009f
Submitter: Zuul
Branch: master

commit 3693144631a4a29f252ec2e4a82ebc6ad3c2009f
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Apr 16 19:23:58 2018 +0200

    Lint directory instead of files and match exclude from oooq-extra.

    Linting the directory leads to different result, with a lot more
    errors caught.

    As a corollary adjust the lint exclude list to match the oooq extra
    exclude list.

    Change-Id: I4846fb4f4bda29d991e4e36de38dc10f02bcd4ed
    Related-Bug: #1764454

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/563574

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564438
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=9e67560f9017409aba9f205045843933f2316990
Submitter: Zuul
Branch: stable/queens

commit 9e67560f9017409aba9f205045843933f2316990
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Apr 16 18:41:06 2018 +0200

    Adhere to ANSIBLE0011 All tasks should be named.

    Change-Id: Idfe041fba9120964a5af06b3a25c55b87b611960
    Closes-Bug: #1764454
    (cherry picked from commit 2bead7f8be288c1e3ad67026e4576108e5696d03)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563574
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=012c222182f8c3dcfebd6d24fe2e9c1942439405
Submitter: Zuul
Branch: stable/queens

commit 012c222182f8c3dcfebd6d24fe2e9c1942439405
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Apr 16 19:23:58 2018 +0200

    Lint directory instead of files and match exclude from oooq-extra.

    Linting the directory leads to different result, with a lot more
    errors caught.

    As a corollary adjust the lint exclude list to match the oooq extra
    exclude list.

    Change-Id: I4846fb4f4bda29d991e4e36de38dc10f02bcd4ed
    Related-Bug: #1764454
    (cherry picked from commit 3693144631a4a29f252ec2e4a82ebc6ad3c2009f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-upgrade 3.0.0 release.