Multiple times retrieve information of project_id in Delete domain

Bug #1764282 reported by lucky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
wangxiyuan

Bug Description

In Delete domain usecase, Redundant SQL queries are getting executed, which can lead to performance delay.
In Delete domain use case, select query is executed multiple times to retrieve information of project_id. This must be reduced to enhance the performance.

Code change is required for handling the redundant SQL queries.
There is a need to change the code in keystone/token/backends.sql.py so that the extra queries will be removed.

Revision history for this message
Lance Bragstad (lbragstad) wrote :

Thanks for the bug report. I can imagine there is some duplication here. Did you use a tool or have specific steps to determine the redundancies?

Setting the priority here to Low since a common workaround is to enable caching.

description: updated
Changed in keystone:
importance: Undecided → Low
status: New → Triaged
tags: added: performance
Revision history for this message
lucky (luckysingh) wrote :

@lance Bragstad : I have enabled mysql logs and then verified it.

summary: - Mutilple times retrieve information of project_id in Delete domain
+ Multiple times retrieve information of project_id in Delete domain
tags: added: sql
wangxiyuan (wangxiyuan)
Changed in keystone:
assignee: nobody → wangxiyuan (wangxiyuan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/589027

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/589027
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=44da48f013881e87f8ac099cf7462d00d804ddd3
Submitter: Zuul
Branch: master

commit 44da48f013881e87f8ac099cf7462d00d804ddd3
Author: wangxiyuan <email address hidden>
Date: Mon Aug 6 15:05:25 2018 +0800

    Remove redundant get_project call

    This patched removed some redundant "get_project" calls when
    deleting projects/domains.

    Change-Id: Ife4dd18962077bac30fa1cecf7621cc86a62929c
    Closes-bug: #1764282

Changed in keystone:
status: In Progress → Fix Released
Changed in keystone:
milestone: none → rocky-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 15.0.0.0rc1

This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.