nova-designate-relation-broken hook definition is missing

[Tytus Kurek]

It looks like the latest version of the nova-compute charm is missing a definition of the "nova-designate-relation-broken" hook:

https://github.com/openstack/charm-nova-compute/blob/master/hooks/nova_compute_hooks.py

Although the designate <-> nova-compute relation has been replaced with designate <-> neutron-api relation in OpenStack charms release 18.02, it causes issues when migrating from old environments which used to use the designate <-> nova-compute relation:

2018-04-13 07:44:48 INFO juju-log nova-designate:90: Unknown hook nova-designate-relation-broken - skipping.

One of the results is that "nova.conf" file is not updated to reflect the changes which are introduced by removing the relation (e.g. disabling "notifications_designate" topic).

Attaching full log from one of the compute nodes.

[Tytus Kurek (tkurek)]

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/561197

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561197
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=4d1220d1fb6fff862ce783dafdcdbaa3953417dd
Submitter: Zuul
Branch: master

commit 4d1220d1fb6fff862ce783dafdcdbaa3953417dd
Author: Tytus Kurek <email address hidden>
Date: Fri Apr 13 13:07:54 2018 +0200

    Add 'nova-designate-relation-broken' hook

    This patchset add 'nova-designate-relation-broken' hook definition
    which is required to update nova-compute configuration files when
    removing the legacy relation with designate.

    Change-Id: I65f5b4ea4f3a6d3bf56a4df2f11da2d750e68e7a
    Closes-Bug: 1763614