Automatically copy group portfolio into group member accounts

Bug #1763163 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

It shall be possible for a group admin / tutor to create a portfolio in a group and then push it to existing group members automatically.

A new option is added to the "Advanced options" in "Edit access" to allow for that in a group.

Thanks to Dublin City University for funding this feature.

Related branches

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8799

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8847

Revision history for this message
Steven (stevens-q) wrote :
Download full text (3.8 KiB)

Tested: in previous patch
1. Group associated with institution.
2. Group members, tutors and admins. Only group members receive copies of portfolios (pages and collections).
3. Set copy to existing members to no, save and set to yes again -> portfolio copied yet again fully into all existing accounts as expected. Fancy rules around not copying were out of scope.
4. No copies made automatically to new group members (out of scope).
-------------------------------------------------------------------------

Test that both on an upgraded site (group, members and portfolios already exist) and on a new install in both MySQL and Postgres

A. Site to upgrade
=========================
Preconditions: Set up groups 1 and 2
-------------------------------------------------------------
1. Group 1 contains a page and a collection with 2 pages. 2 members and 1 admin.
2. Group 2 contains a page and a collection with 2 pages. 2 members, 1 tutor and 1 admin.
3. Upgrade the site to patch 8847

Test Script - Group 1: Members and Admin
-------------------------------------------------------------
1. Member sets up a page -> doesn't have option to copy to existing group members. ✔
2. Admin looks at the page and can select the copy to existing group members. ✔
3. Admin sets up a collection and copies that into existing user accounts. ✔
4. Confirm Admin and Tutors don't get portfolios copied ✔
5. Add a new member to the group. ✔
6. Confirm new group members do not get the previously copied portfolios. ✔
7. Add a new page to the group and set that to copy to existing members.
8. Confirm old members and new members to get a copy. ✔
9. Confirm The "Copy to existing group members" button switches back to "No" once the "Edit access" form was saved. ✔
10. User at a later time if set to 'Yes' again it will do the copying
11. Confirm any newer members receive a copy of all pages/collections as ✔
12. Confirm older members receive copies of any new pages / collections since the previous switching to 'No' ✔
13. Confirm that any portfolios copied only end up in group member accounts. Neither admin nor tutor ever receive copies. ✔

Group 2: Members, tutor, admin
--------------------------------
1. Run the above script logged in as Tutor
2. Confirm that the functionality is working as expected ✔

B. New site
===============
Preconditions: Set up groups 1 and 2
1. Clear out database.
2. Install patch 8847
3. Set up site.
4. Group 1 contains a page and a collection with 2 pages. 2 members and 1 admin.
5. Group 2 contains a page and a collection with 2 pages. 2 members, 1 tutor and 1 admin.

Test Script - Group 1: Members and Admin
------------------------------------------
1. Member sets up a page -> doesn't have option to copy to existing group members. ✔
2. Admin looks at the page and can select the copy to existing group members. ✔
3. Admin sets up a collection and copies that into existing user accounts. ✔
4. Add a new member to the group. ✔
5. Confirm new group members do not get the previously copied portfolios. ✔
6. Add a new page to the group and set that to copy to existing members.
7. Confirm old members and new members to get a copy. ✔
8. Confirm The "Copy to existing...

Read more...

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8795
Committed: https://git.mahara.org/mahara/mahara/commit/01af3dab2d3e5020a9778177601f8b55bfdc8830
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 01af3dab2d3e5020a9778177601f8b55bfdc8830
Author: Robert Scally <email address hidden>
Date: Tue Apr 10 15:36:51 2018 +0100

Bug 1763163: Copy group portfolios automatically to existing group members

A portfolio shall be copied automatically to existing regular group
members, i.e. excluding group tutors and administrators, when
setting up the sharing permissions for the portfolio and selecting the
copying option in "Advanced options".

When new people are added to the group, the portfolio is not automatically
copied to their accounts as they were not in the group when the copying
was turned on.

behatnotneeded

Change-Id: I5f706056e3c53f1edc8bcb86cfd41bad1df0185b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8847
Committed: https://git.mahara.org/mahara/mahara/commit/1dcaef8588ff75ea69051a1af6d1b45f9b106119
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1dcaef8588ff75ea69051a1af6d1b45f9b106119
Author: Robert Lyon <email address hidden>
Date: Thu May 10 13:47:21 2018 +1200

Bug 1763163: record who has been given what page for one time copy

This changes the parent patch a bit. Instead of recording on the view
table if a page is able to be copied to existing group members we
insetad record in a new existing copy table if a group page/collection
has been copied to a member and if not make the copy.

We've also made the switch a slide switch, eg when switching it to
'Yes' it does the task on save and then switches back to 'No'.

This means at a later time if set to 'Yes' again it will do the copying
again and give any newer members a copy of all pages/collections as
well as give older members copies of any newer pages / collections /
collection pages since the previous switching to 'No'

Note: Currently adding new collection pages to older members will only
add the pages as singular pages to their portfolio.

behatnotneeded

Change-Id: Ia22d8138d80ec5fdb5a401de7289b256f9e5fc69
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
description: updated
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.