casper-helpers:try_mount doesn't honor the mount point

Bug #1762920 reported by Tomo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
casper (Ubuntu)
New
Undecided
Unassigned

Bug Description

I apologize for direct mentioning to the source codes.
Problem:
 try_mount() in casper-helpers script doesn't honor the mount-point parameter when mount-option != "ro".
 This is obvious on code, but it wouldn't what it meant to be.
 I guess,
   if the device is already mounted on A, and
     if the indicated mount point of which is the same as previous mounted (i.e. A; where_is_mounted() says),
      do mount -o remount ...
   else
      do mount -o bind ...
   whatever the indicated mount options are.

  This spec suffers in the case,
   setting persistence YES, boot media, especially USB, is multi-partitioned, and persistence data are on separated part from the base boot image.
      In that case, find_cow_device() falsely unmount /cdrom (because where_is_mounted() says '/cdrom' was
   previous mount point in the device searching iteration) and gone busybox prompt.
  There might be a fix find_cow_device() itself but, I thought that try_mount() is fundamental.

A patch attached is a sample to solve this.

Notice:
An attached patch was from my own fixed version, and contains find_cow_device() modification. Be careful when applying.

Tags: patch
Revision history for this message
Tomo (tomoyuki) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "PATCH: casper-helpers try_mount() diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Tomo (tomoyuki)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.