Juju should add new machine after version sorting bundle machines
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Juju |
Fix Released
|
Medium
|
Tim Penhey | ||
2.3 |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
$ juju version
2.3.5-xenial-amd64
When deploying a bundle, Juju adds bundle machines from 0, 1, 10, 11, ..., 2, 20. Considering that Juju also supports "--map-machines existing,X=Y" for re-running `juju deploy`. It would be definitely straightforward if Juju adds bundle machines after sorting numerics naturally (version sort). So that we don't need to pass "X=Y" less frequently. See an actual and expected outputs below.
[actual]
$ juju deploy ./bundle.yaml
...
- add new machine 0
- add new machine 1
- add new machine 2 (bundle machine 10)
- add new machine 3 (bundle machine 11)
- add new machine 4 (bundle machine 12)
- add new machine 5 (bundle machine 13)
- add new machine 6 (bundle machine 14)
- add new machine 7 (bundle machine 15)
- add new machine 8 (bundle machine 16)
- add new machine 9 (bundle machine 17)
- add new machine 10 (bundle machine 18)
- add new machine 11 (bundle machine 19)
- add new machine 12 (bundle machine 2)
- add new machine 13 (bundle machine 20)
- add new machine 14 (bundle machine 21)
- add new machine 15 (bundle machine 22)
- add new machine 16 (bundle machine 3)
- add new machine 17 (bundle machine 4)
- add new machine 18 (bundle machine 5)
- add new machine 19 (bundle machine 6)
- add new machine 20 (bundle machine 7)
- add new machine 21 (bundle machine 8)
- add new machine 22 (bundle machine 9)
[expected]
$ juju deploy ./bundle.yaml
...
- add new machine 0
- add new machine 1
- add new machine 2 (bundle machine 2)
- add new machine 3 (bundle machine 3)
- add new machine 4 (bundle machine 4)
- add new machine 5 (bundle machine 5)
- add new machine 6 (bundle machine 6)
- add new machine 7 (bundle machine 7)
- add new machine 8 (bundle machine 8)
- add new machine 9 (bundle machine 9)
- add new machine 10 (bundle machine 10)
- add new machine 11 (bundle machine 11)
- add new machine 12 (bundle machine 12)
- add new machine 13 (bundle machine 13)
- add new machine 14 (bundle machine 14)
- add new machine 15 (bundle machine 15)
- add new machine 16 (bundle machine 16)
- add new machine 17 (bundle machine 17)
- add new machine 18 (bundle machine 18)
- add new machine 19 (bundle machine 19)
- add new machine 20 (bundle machine 20)
- add new machine 21 (bundle machine 21)
- add new machine 22 (bundle machine 22)
Changed in juju: | |
status: | Triaged → In Progress |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 2.4-beta2 |
Changed in juju: | |
status: | In Progress → Fix Committed |
tags: | added: canonical-bootstack |
Changed in juju: | |
status: | Fix Committed → Fix Released |
I *think* this is just changing an alphabetical sort into a numeric lexical sort, and we have that function somewhere.