[R5.0-50]- 2 set of Fat flows are created for same endpoints and proto

[alok kumar]

when source and destination ports are same and Fat flow is configured with same port then for single flow 2 sets of flows are getting created.

source VM: 1.1.1.3
Dest VM: 1.1.1.4 with below Fat configs:

vif0/3 OS: tap0199a3fa-d3
            Type:Virtual HWaddr:00:00:5e:00:01:00 IPaddr:1.1.1.4
            Vrf:2 Mcast Vrf:2 Flags:PL3L2DEr QOS:-1 Ref:6
            RX packets:269 bytes:20407 errors:0
            TX packets:281 bytes:20949 errors:0
            Drops:242
            FatFlows (Protocol/Port): 1:* - Dip, 6:* - Dip, 6:22 - Dip, 17:10000

when traffic started from 1.1.1.3:10000 to 1.1.1.4:10000 then below flows are created on dest VM's node:

    Index Source:Port/Destination:Port Proto(V)
-----------------------------------------------------------------------------------
   112476<=>406524 1.1.1.4:0 17 (2)
                         1.1.1.3:10000
(Gen: 7, K(nh):19, Action:F, Flags:, QOS:-1, S(nh):19, Stats:1/73, SPort 57202,
 TTL 0, Sinfo 3.0.0.0)

   244244<=>396216 1.1.1.4:10000 17 (2)
                         1.1.1.3:0
(Gen: 5, K(nh):19, Action:F, Flags:, QOS:-1, S(nh):19, Stats:0/0, SPort 64673,
 TTL 0, Sinfo 0.0.0.0)

   396216<=>244244 1.1.1.3:0 17 (2)
                         1.1.1.4:10000
(Gen: 5, K(nh):19, Action:F, Flags:, QOS:-1, S(nh):29, Stats:1/45, SPort 55607,
 TTL 0, Sinfo 10.204.217.102)

   406524<=>112476 1.1.1.3:10000 17 (2)
                         1.1.1.4:0
(Gen: 7, K(nh):19, Action:F, Flags:, QOS:-1, S(nh):29, Stats:0/0, SPort 49905,
 TTL 0, Sinfo 0.0.0.0)

[Hari Prasad Killi (haripk)]

matching source and destination ports would be a very rare scenario.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41792
Submitter: Ashok Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41884
Submitter: Ashok Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41792
Committed: http://github.com/Juniper/contrail-controller/commit/ad34efff61d6a0f2d5ed86ebe5ccf0adc2e748b6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ad34efff61d6a0f2d5ed86ebe5ccf0adc2e748b6
Author: Ashok Singh R <email address hidden>
Date: Thu Apr 12 13:55:39 2018 +0530

Fix issue of multiple flow creation.

When fat-flow is configured we see different set of flows getting created
for forward and reverse traffic when source and destination ports are same.
This is fixed by always masking source port for both forward and reverse
flows.

Change-Id: I28a43cca04e0c15504446b4411704bed24076487
Closes-Bug: #1761517

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41884
Committed: http://github.com/Juniper/contrail-controller/commit/d9dca54af15737960a7d6fff6fb43bb4ed6b591e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit d9dca54af15737960a7d6fff6fb43bb4ed6b591e
Author: Ashok Singh R <email address hidden>
Date: Thu Apr 12 13:55:39 2018 +0530

Fix issue of multiple flow creation.

When fat-flow is configured we see different set of flows getting created
for forward and reverse traffic when source and destination ports are same.
This is fixed by always masking source port for both forward and reverse
flows.

Closes-Bug: #1761517
(cherry picked from commit ad34efff61d6a0f2d5ed86ebe5ccf0adc2e748b6)

Change-Id: I5cc59d1e70e860b2388d100ae49a4d3b5a13253c