tripleo

ansible.py mistral action is passing env variables without casting them to string

Bug #1761232 reported by Giulio Fidente on 2018-04-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Giulio Fidente	tripleo rocky-1

Bug Description

Looks like processutils.execute expects env_variables to be a map where keys and values are strings; when an integer is passed it will fail with something like:

TypeError: execve() arg 3 contains a non-string value

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-04: Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/558865

Changed in tripleo:
assignee:	nobody → Giulio Fidente (gfidente)
status:	Triaged → In Progress

Bogdan Dobrelya (bogdando) on 2018-04-05

Changed in tripleo:
importance:	Low → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-17: Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/558865
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=242b6714e6fad9111440b5413bcbc66427c4bc72
Submitter: Zuul
Branch: master

commit 242b6714e6fad9111440b5413bcbc66427c4bc72
Author: Giulio Fidente <email address hidden>
Date: Wed Apr 4 18:15:39 2018 +0200

Enforce env_variables values to string before run

Converts extra_env_variables values to string because processutils
expect them to be so.

Change-Id: If033001d53f9163ef998fcd162dff1b76fb586d7
Closes-Bug: #1761232

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-17: Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/561966

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-17: Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.openstack.org/561966
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1a502596cd66875cc54215dbbb281229ab62bbe2
Submitter: Zuul
Branch: stable/queens

commit 1a502596cd66875cc54215dbbb281229ab62bbe2
Author: Giulio Fidente <email address hidden>
Date: Wed Apr 4 18:15:39 2018 +0200

Enforce env_variables values to string before run

Converts extra_env_variables values to string because processutils
expect them to be so.

    Change-Id: If033001d53f9163ef998fcd162dff1b76fb586d7
    Closes-Bug: #1761232
    (cherry picked from commit 242b6714e6fad9111440b5413bcbc66427c4bc72)