[Konqueror 3.5.8] Ad Block Plus doesn't work after list upgrade

[Uqbar]

Binary package hint: konqueror

I've tried to upgrade the Ad Block Plus definition list. I've done the following:
1. exported the current list (Last Modified: 26Sep07) to a local file
2. downloaded the new one from the website at http://easylist.adblockplus.org/adblock_rick752.txt
3. erased the current list
4. imported the new one
5. closed and re-open the browser

Now everything (also non-ad contents) gets filtered out, unless I disable the filter.
What's worst is that by restoring the exported file I'm not able to have the Ad Block Plus working anymore.
I'd like to be able to upgrade to the new definitions or, at least, to restore the old ones.

[Guillaume Martres (smarter)]

Konqueror Adblock doesn't support whitelisting(@@), try to remove the lines starting with @@ in the updated list.

[Uqbar (uqbar)]

Il Friday 14 December 2007 20:30:31 Guillaume Martres ha scritto:
> Konqueror Adblock doesn't support whitelisting(@@), try to remove the
> lines starting with @@ in the updated list.

Nope!
I commented out the @@ lines but now I cannot see any graphics in any
website.
My reference site is slashdot.org.
Now the ads get filtered, but also the graphical components of the page.

Any other hint?

--
Vincenzo Romano
Maybe Computers will never become as intelligent as Humans.
Surely they won't ever become so stupid. [VR-1989]

[Guillaume Martres (smarter)]

You should also remove the lines that begin with a ! and the first line "[Adblock Plus 0.7.1]", then reload slashdot.

[Uqbar (uqbar)]

Il Friday 14 December 2007 23:18:05 Guillaume Martres ha scritto:
> You should also remove the lines that begin with a ! and the first line
> "[Adblock Plus 0.7.1]", then reload slashdot.

It seems it works now.
As far as I remember the "bang lines" (the ones beginning with "!") used to be
present also in the original adblock definition ...

I'll do a better check and will eventually close this, though I think that if
we call it "AdBlock" it should work with AdBlock files, at least by filtering
out the unsupported thinga during the "Import".

--
Vincenzo Romano
Maybe Computers will never become as intelligent as Humans.
Surely they won't ever become so stupid. [VR-1989]

[Uqbar (uqbar)]

It works as it used to do on a number of sites I've tested.

I would say that the "fixes" Guillaume suggets should be actually called bug workarounds.
The default AdBlock definition file loaded into konqueror had both the bang lines and the "[Adblock Plus" header.

So I would hope for real fixes, like filtering out unsupported predicates from the definition files.

[Guillaume Martres (smarter)]

In fact, the default list doesn't have the "[Adblock ...]" line, and if you try to add a line that start with a "[", everything is filtered, I'll try to fix that later.

[Guillaume Martres (smarter)]

I've made a patch to treat leading "[" as comments(like "!").

[Harald Sitter (apachelogger)]

Guillaume Martres, please report this upstream and post the patch there.

[Jonathan Thomas (echidnaman)]

Works in KDE4.