config-download: don't log set_fact tasks that read role_data_* files

Bug #1760996 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
James Slagle

Bug Description

In common/deploy-steps-tasks.yaml the tasks that set the contents of the role_data_* file as facts are very verbose since the whole file's contents are logged in the task's results.

use no_log here to be less verbose.

Revision history for this message
James Slagle (james-slagle) wrote :
Changed in tripleo:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → James Slagle (james-slagle)
milestone: none → rocky-2
tags: added: config-download
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/558636

Changed in tripleo:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/558636
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f044539b1cade9b343051c81b2f18dadd8b7c918
Submitter: Zuul
Branch: master

commit f044539b1cade9b343051c81b2f18dadd8b7c918
Author: James Slagle <email address hidden>
Date: Tue Apr 3 17:43:57 2018 -0400

    Don't log set_fact tasks for role_data

    set_fact logs the fact value. In the case of reading the role_data_*
    files, this is very verbose as the files can be large. Use no_log: True
    to make these tasks less verbose. The content is saved in the
    config-download output already, so no useful info is lost.

    Change-Id: Ie6f75113194961628a0c9bdfbfbf5d88a18059eb
    Closes-Bug: #1760996

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0b2

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/582426

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/582426
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=cc62709055cd06c139ce4c534d73f369da674dbf
Submitter: Zuul
Branch: stable/queens

commit cc62709055cd06c139ce4c534d73f369da674dbf
Author: James Slagle <email address hidden>
Date: Tue Apr 3 17:43:57 2018 -0400

    Don't log set_fact tasks for role_data

    set_fact logs the fact value. In the case of reading the role_data_*
    files, this is very verbose as the files can be large. Use no_log: True
    to make these tasks less verbose. The content is saved in the
    config-download output already, so no useful info is lost.

    Change-Id: Ie6f75113194961628a0c9bdfbfbf5d88a18059eb
    Closes-Bug: #1760996
    (cherry picked from commit f044539b1cade9b343051c81b2f18dadd8b7c918)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.5

This issue was fixed in the openstack/tripleo-heat-templates 8.0.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.