web staff client: missing images on transit and holds slips

Bug #1760859 reported by Jeanette Lundgren
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.0
Fix Released
Low
Unassigned

Bug Description

In the XUL client there are images for the transit slip (truck) and holds slip (books).

The web client slips do not have images (confirmed on 3.0.6)

Our libraries find these helpful and asked if they could be added back.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Marking this Confirmed. I am also not seeing the images on our 3.1.beta test server.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jeanette Lundgren (jlundgren) wrote :

It looks like you can add the image link to the print templates, but I am working on a fix to get the image link into the stock templates (otherwise we will have to customize both templates for all of our 150 libraries)...

Changed in evergreen:
assignee: nobody → Jeanette Lundgren (jlundgren)
Revision history for this message
Jeanette Lundgren (jlundgren) wrote :

I added the img tag with alt text to t_hold_shelf_dialog.tt2 to use the holds.png image found on the portal page in the web client (i.e. stack of books) to the pop-up dialog that displays when a checked in title goes intransit. This has no impact on the print template for holds shelf.

I created a new transit.png image which is more web clientesque and added an img tag with alt text to t_transit_dialog.tt2 Basicaly, I modified a truck icon from Aiconica http://aiconica.net which has no copyright restrictions (public domain) https://creativecommons.org/publicdomain/zero/1.0/ If you have a better image by all means...

Examples of current XUL and new WEB dialogs with images are here: https://docs.google.com/document/d/1gJ5PRjIbh7rTvYKAt1dEEaNWiRL_AM9gyQytfYPUzE4/edit?usp=sharing

Signed off and pushed branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=6c8d54d7d8eacc77324a4e6795c7ef1e55401b06

tags: added: pullrequest
Changed in evergreen:
status: Confirmed → In Progress
assignee: Jeanette Lundgren (jlundgren) → nobody
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I added my signoff and cleaned up the commit message a bit in user/dyrcona/lp1760589-signoff:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1760859-signoff

Thanks, Jeanette!

Changed in evergreen:
status: In Progress → Confirmed
milestone: none → 3.2-beta
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_1, and rel_3_0. Thanks, Jeanette and Jason!

Changed in evergreen:
milestone: 3.2-beta → 3.1.2
no longer affects: evergreen/3.1
Changed in evergreen:
importance: Undecided → Low
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.