vpnaas unit test is broken with no such option metadata_access_mark in group [DEFAULT]

[Akihiro Motoki]

After https://review.openstack.org/#/c/524406/ is merged, neutron-vpnaas unit test is broken.
http://logs.openstack.org/94/543394/12/check/openstack-tox-py27/61b9f31/

example failure:

ft5.41: neutron_vpnaas.tests.unit.services.vpn.device_drivers.test_ipsec.TestOpenSwanProcess.test_sync_StringException: Traceback (most recent call last):
  File "neutron_vpnaas/tests/unit/services/vpn/device_drivers/test_ipsec.py", line 1117, in setUp
    super(TestOpenSwanProcess, self).setUp(driver, ipsec_process)
  File "neutron_vpnaas/tests/unit/services/vpn/device_drivers/test_ipsec.py", line 419, in setUp
    self._make_router_info_for_test()
  File "neutron_vpnaas/tests/unit/services/vpn/device_drivers/test_ipsec.py", line 424, in _make_router_info_for_test
    **self.ri_kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/neutron-vpnaas/.tox/py27/local/lib/python2.7/site-packages/neutron/agent/l3/router_info.py", line 77, in __init__
    self.initialize_metadata_iptables()
  File "/home/zuul/src/git.openstack.org/openstack/neutron-vpnaas/.tox/py27/local/lib/python2.7/site-packages/neutron/agent/l3/router_info.py", line 1006, in initialize_metadata_iptables
    'value': self.agent_conf.metadata_access_mark,
  File "/home/zuul/src/git.openstack.org/openstack/neutron-vpnaas/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2519, in __getattr__
    raise NoSuchOptError(name)
oslo_config.cfg.NoSuchOptError: no such option metadata_access_mark in group [DEFAULT]

[Akihiro Motoki (amotoki)]

It is one example that we need more efforts to decouple unit tests from neutron repo. neutron-vpnaas unit test initializes a router info per router type. Perhaps we need to avoid initializing router info directly in neutron-vpnaas tests, but it will take more time to address it. Short term solution to fix this bug would be to register related L3 opts in neutron-vpnaas code.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/558060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558060
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=e10993c98ccf0500f4b309170c1b82041385568f
Submitter: Zuul
Branch: master

commit e10993c98ccf0500f4b309170c1b82041385568f
Author: Akihiro Motoki <email address hidden>
Date: Sun Apr 1 01:04:56 2018 +0900

    test: Register L3 option in L3 ext tests

    After https://review.openstack.org/#/c/524406/ landed,
    we need to register L3 opts before initializing router info.

    Change-Id: I2017be0e9ca069abfdd1c5250bc06b3b4109fa83
    Closes-Bug: #1760320

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/614277

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/614405

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614277
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=01b9cd4b0157c5510b633184bfd0c825d2429c09
Submitter: Zuul
Branch: stable/queens

commit 01b9cd4b0157c5510b633184bfd0c825d2429c09
Author: Akihiro Motoki <email address hidden>
Date: Sun Apr 1 01:04:56 2018 +0900

    test: Register L3 option in L3 ext tests

    After https://review.openstack.org/#/c/524406/ landed,
    we need to register L3 opts before initializing router info.

    Change-Id: I2017be0e9ca069abfdd1c5250bc06b3b4109fa83
    Closes-Bug: #1760320
    (cherry picked from commit e10993c98ccf0500f4b309170c1b82041385568f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614405
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=b4a3b0b1ec1a50b1c868b2ffc7dda9d05f888689
Submitter: Zuul
Branch: stable/pike

commit b4a3b0b1ec1a50b1c868b2ffc7dda9d05f888689
Author: Akihiro Motoki <email address hidden>
Date: Sun Apr 1 01:04:56 2018 +0900

    test: Register L3 option in L3 ext tests

    After https://review.openstack.org/#/c/524406/ landed,
    we need to register L3 opts before initializing router info.

    Change-Id: I2017be0e9ca069abfdd1c5250bc06b3b4109fa83
    Closes-Bug: #1760320
    (cherry picked from commit e10993c98ccf0500f4b309170c1b82041385568f)
    (cherry picked from commit 01b9cd4b0157c5510b633184bfd0c825d2429c09)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas pike-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas queens-eol release.