effect names cut off on macOS in Deere and LateNight

Bug #1760229 reported by Be
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Unassigned

Bug Description

The effect names in the drop down menu for WEffectSelector are cut off in Deere and LateNight on macOS. In Tango it looks okay. I cannot test Shade because Mixxx crashes trying to load it.

Revision history for this message
Be (be.ing) wrote :
Revision history for this message
Be (be.ing) wrote :
Revision history for this message
Be (be.ing) wrote :
Changed in mixxx:
milestone: none → 2.1.0
importance: Undecided → Medium
Revision history for this message
ronso0 (ronso0) wrote :

IMO it's the default tick mark that is much wider than necessary.
For a quick fix for 2.1.01 have a look at https://github.com/mixxxdj/mixxx/pull/1555 where I fixed it for Tango, especially the comments in style.qss

Revision history for this message
Be (be.ing) wrote :

Hmm, I can't reproduce this on an older Macbook with a 1440 x 900 screen. The MacBook I saw the names cut off was a 2016 15 inch Macbook with a 2880 x 1800 screen.

Revision history for this message
Benis (beenisss) wrote :

I can reproduce this on a 2014 15in MacBook. Shade also has the issue.

Revision history for this message
ronso0 (ronso0) wrote :

I notice the space reserved for the tick mark on OSXY is twice as wide as on Linux (xfce). The root issue seems to be that the (left) padding of the collapsed EffectSelector is also applied to items in effect list, but the elide function doesn't consider this.

Revision history for this message
ronso0 (ronso0) wrote :

Hopefully fixed for LateNight in https://github.com/mixxxdj/mixxx/pull/1578

Revision history for this message
ronso0 (ronso0) wrote :

https://github.com/mixxxdj/mixxx/pull/1578 worked ou for LateNight.
Continued for Shade and Deere in https://github.com/mixxxdj/mixxx/pull/1581

Be (be.ing)
Changed in mixxx:
status: New → Confirmed
Revision history for this message
Be (be.ing) wrote :
Changed in mixxx:
status: Confirmed → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9208

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.