Please sync vinagre (main) 0.4-1 from Debian unstable (main)

[Pedro Fragoso]

Please sync vinagre 0.4-1 (main) from Debian unstable (main).

Explanation of the Ubuntu delta and why it can be dropped:
The Debian package is based on the Ubuntu one, so we can safely sync it. It also includes a new upstream release, and some cleanup and improvements to the packaging

Changelog since current hardy version 0.3-0ubuntu2:

vinagre (0.4-1) unstable; urgency=low

  [ Emilio Pozuelo Monfort ]
  * Initial upload to Debian, stolen from Ubuntu. Closes: #442403.
  * New upstream release.
  * Set myself as Maintainer and the Debian GNOME Team as Uploader.
  * debian/control:
    - Bump libgtk-vnc-1.0-dev build dependency to 0.3.
    - Added libgnome-keyring-dev and libgnomevfs2-dev to Build-Depends.
    - Bump Standards-Version to 3.7.3.
    - Wrap Build-Depends.
    - Add Homepage, Vcs-Browser and Vcs-Svn fields.
    - Reworked long description.
  * debian/rules:
    - Don't manually gzip upstream's ChangeLog. Let CDBS/debhelper do
      the work.
    - Call dh_icons in binary-install rule, as gnome.mk doesn't call it yet.
      This is reported as #432851.
  * debian/vinagre.1:
    - Rewritten.

  [ Josselin Mouette ]
  * Fix the build-dependencies according to configure.ac's contents.

 -- Emilio Pozuelo Monfort <email address hidden> Sun, 13 Jan 2008 13:20:06 +0100

[Pedro Fragoso (ember)]

http://revu.tauware.de/details.py?upid=965

[Daniel Holbach (dholbach)]

Sorry, bug spam necessary because of bug 176085.

This bug has a patch attached, which needs review and sponsoring.

[Emmet Hikory (persia)]

I've unsubscribed ubuntu-universe-sponsors, as this shouldn't be uploaded yet. Please resubscribe once the dependency is resolved to request upload.

[Emmet Hikory (persia)]

I was unable to reconstruct the target diff.gz from the provided interdiff. Please do not use the -p1 argument when submitting for review. With REVU down, the diff.gz was not available from other sources. Please recreate a working interdiff, and resubmit to the sponsors queue to request upload.

[Marco Rodrigues (gothicx)]

The watch file is working ? It says at http://qa.ubuntuwire.com/uehs/no_upstream.php that isn't and I don't see anything related to it in your interdiff.

[Pedro Fragoso (ember)]

-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   http://ftp.gnome.org/pub/GNOME/sources/vinagre/([\d\.]+)/vinagre-([\d\.]+)\.tar\.gz debian uupdate
-- Found the following matching hrefs:
     vinagre-0.4.tar.gz
     vinagre-0.4.tar.gz
Newest version on remote site is 0.4, local version is 0.4
 => Package is up to date
-- Scan finished

[Emilio Pozuelo Monfort (pochu)]

I've looked at the REVU package but it looks a bit old, and I guess you have done some changes to it. If you could attach a diff.gz here I'd take a look at it.

[Emilio Pozuelo Monfort (pochu)]

And as Emmet pointed out, we need gtk-vnc 0.4 for this. Is there some progress in that somewhere?

[Emilio Pozuelo Monfort (pochu)]

(I don't know whether this is fixed in your interdiff, but as it's b0rked...)

In fact we don't need gtk-vnc 0.4, and the Build-Depends should be bumped to 0.3 and not 0.4:

$ diff vinagre-0.{3,4}/configure.ac | grep VNC
+GTK_VNC_REQUIRED=0.3
+ gtk-vnc-1.0 >= $GTK_VNC_REQUIRED)

And you need to add Build-Depends for these ones too:

checking for VINAGRE... configure: error: Package requirements ( glib-2.0 >= 2.11.0 gtk+-2.0 >= 2.11.0 libglade-2.0 >= 2.6.0 gconf-2.0 >= 2.16.0 gnome-keyring-1 gnome-vfs-2.0 gtk-vnc-1.0 >= 0.3) were not met:

No package 'gnome-keyring-1' found
No package 'gnome-vfs-2.0' found

[Emilio Pozuelo Monfort (pochu)]

Unsubscribing ubuntu-universe-sponsors for now. Please resubscribe it when the above issues are fixed.

[Jonh Wendell (wendell)]

gtk-vnc 0.4 doesn't exist.

I prefer to depend on latest available version, 0.3.2.

[Pedro Fragoso (ember)]

Pochu: That was fixed on interdiff.

Wendell: I had build deps on gtk-vnc 0.3.1 bumped to gtk-vnc 0.3.2

[Emmet Hikory (persia)]

Err. I was waiting for gtk-vnc 0.3.0. We now have 0.3.2, so that should be fine. On the other hand, this interdiff was generated with -p1, and so cannot be used to construct the target diff.gz. Separately, If the dependency got gtk-vnc has beem bumped to 3.1 ("libgtk-vnc-1.0-dev (>= 0.3.1)"), the changelog shouldn't say "Added Depend for gtk-vnc 3.0".

[Emmet Hikory (persia)]

Given the timing of the new candidate and my last comment, I've given it a new review.

1) Why bump Build-Depends to 3.2? Was there an API change that would otherwise break? Build-Dependencies should be set as low as possible to accurately reflect what is required. The package will actually build against the newest version in the archive at build-time.

2) You've updated the Standards-Version, but the new package fails to comply with Standards-Version 3.7.3. Specifically, the ChangeLog is not being installed properly. Instead of the manual workarounds, it is better to use DEB_INSTALL_CHANGELOGS_ALL for a CDBS package. Alternately, also rename it when compressing it.

3) The changelog really ought close this bug.

4) Don't forget to resubscribe the sponsors and unassign yourself when submitting a new candidate. The bug may well get ignored otherwise.

[Jonh Wendell (wendell)]

> 1) Why bump Build-Depends to 3.2? Was there an API change that would
> otherwise break? Build-Dependencies should be set as low as possible to
> accurately reflect what is required. The package will actually build
> against the newest version in the archive at build-time.

You mean 0.3.2, right?
0.3.0 is uninstallable.
0.3.2 has some fixes and new encodings, and I personally prefer this
version for Vinagre.

Perhaps we'll have new versions for both gtk-vnc and vinagre, in time
for Hardy. Let's see...

--
Jonh Wendell
www.bani.com.br

[Emilio Pozuelo Monfort (pochu)]

Jonh Wendell wrote:
>> 1) Why bump Build-Depends to 3.2? Was there an API change that would
>> otherwise break? Build-Dependencies should be set as low as possible to
>> accurately reflect what is required. The package will actually build
>> against the newest version in the archive at build-time.
>
> You mean 0.3.2, right?
> 0.3.0 is uninstallable.
> 0.3.2 has some fixes and new encodings, and I personally prefer this
> version for Vinagre.

Since it will be >= 0.3 and not = 0.3, there's no problem with 0.3.0 being
uninstallable (also, do you mean uninstallable as in it's buggy or as in it's
superseded?). The buildds will pick up the latest one available, which is 0.3.2
actually.

I can't see why it should require 0.3.2... if there's a big reason (and I don't
think there is) then that would be ok, but then you would want to bump it in
vinagre's configure.ac.

[Jonh Wendell (wendell)]

> but then you would want to bump it in
> vinagre's configure.ac.

Ah, of course. Thanks for pointing this out ;)
Item added in my todo list :)

--
Jonh Wendell
www.bani.com.br

[Emilio Pozuelo Monfort (pochu)]

I've packaged vinagre in Debian and is now in the NEW queue. We can request a sync once it's newed.

[Emilio Pozuelo Monfort (pochu)]

Unsubscribing u-u-s, I'll change this to a sync request once vinagre is newed in Debian.

[Pedro Fragoso (ember)]

Thanks Emilio.

[Soren Hansen (soren)]

ACK

[Martin Pitt (pitti)]

synced