get-occ-config.sh no longer works with roles with a count greater than 1

[James Slagle]

sample log:
https://pastebin.com/kn6Q8TSJ

notice how the script just exits after ((i++)) even though there were multiple stacks in the $stacks var.

This is because the bash expression ((i++)) evaluates to 0, so returns 1, causing the script to exit.

We need to revert this line back to let i+=1

[James Slagle (james-slagle)]

https://review.openstack.org/557346

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/557346

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557346
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=154879b68dfe3ff3834babcfb1d619a4d05044af
Submitter: Zuul
Branch: master

commit 154879b68dfe3ff3834babcfb1d619a4d05044af
Author: James Slagle <email address hidden>
Date: Wed Mar 28 10:08:39 2018 -0400

    get-occ-config.sh: fix handling multiple nodes in a role

    When using get-occ-config.sh with a role with a count greater
    than 1, the script will now configure all nodes that are of that role
    type instead of exiting after only configuring the first.

    Previously, the expression ((i++)) evaluated to 0, and when using
    arithmetic expansion, causes a rc of 1, which caused the script to exit
    after configuring the first node.

    Change-Id: I0a39f2b8f1de5302fd426999acfe5043b0361987
    Closes-Bug: #1759581

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/558242

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558242
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d97fc05d399e9021c37bbec171790032a692b5f3
Submitter: Zuul
Branch: stable/queens

commit d97fc05d399e9021c37bbec171790032a692b5f3
Author: James Slagle <email address hidden>
Date: Wed Mar 28 10:08:39 2018 -0400

    get-occ-config.sh: fix handling multiple nodes in a role

    When using get-occ-config.sh with a role with a count greater
    than 1, the script will now configure all nodes that are of that role
    type instead of exiting after only configuring the first.

    Previously, the expression ((i++)) evaluated to 0, and when using
    arithmetic expansion, causes a rc of 1, which caused the script to exit
    after configuring the first node.

    Change-Id: I0a39f2b8f1de5302fd426999acfe5043b0361987
    Closes-Bug: #1759581
    (cherry picked from commit 154879b68dfe3ff3834babcfb1d619a4d05044af)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/574728

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/574728
Reason: The gate is having serious troubles with docker.io, we need to abandon this patch so it leaves the gate and when it's stable again I will restore this patch. Please do not restore or do anything, I'll take care of it as soon as things work again.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/574728

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/574728
Reason: we have gate problems again, please do not restore or recheck, I'll take care of this one when gate is back stable.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574728
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=95f19a7e3e52de175926557e09e73f93e8f79d5a
Submitter: Zuul
Branch: stable/pike

commit 95f19a7e3e52de175926557e09e73f93e8f79d5a
Author: James Slagle <email address hidden>
Date: Wed Mar 28 10:08:39 2018 -0400

    get-occ-config.sh: fix handling multiple nodes in a role

    When using get-occ-config.sh with a role with a count greater
    than 1, the script will now configure all nodes that are of that role
    type instead of exiting after only configuring the first.

    Previously, the expression ((i++)) evaluated to 0, and when using
    arithmetic expansion, causes a rc of 1, which caused the script to exit
    after configuring the first node.

    Change-Id: I0a39f2b8f1de5302fd426999acfe5043b0361987
    Closes-Bug: #1759581
    (cherry picked from commit 154879b68dfe3ff3834babcfb1d619a4d05044af)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.14 release.