Fail to fetch router resource by name instead of UUID

[Édouard Thuleau]

As a non admin user:

$ openstack router list
+--------------------------------------+---------+--------+-------+-------------+-------+----------------------------------+
| ID | Name | Status | State | Distributed | HA | Project |
+--------------------------------------+---------+--------+-------+-------------+-------+----------------------------------+
| d9003cb6-8666-4473-b5eb-9ad0db2acf3e | router1 | ACTIVE | UP | False | False | 42040ac8030a43c29cdb4b5696208e49 |
+--------------------------------------+---------+--------+-------+-------------+-------+----------------------------------+
$ openstack router show router1
HttpException: Unknown error
$ openstack router show d9003cb6-8666-4473-b5eb-9ad0db2acf3e
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| admin_state_up | UP |
| availability_zone_hints | None |
| availability_zones | None |
| created_at | None |
| description | None |
| distributed | False |
| external_gateway_info | {"network_id": "09fe6429-cce4-4edf-8588-88de6a036fb4", "enable_snat": true} |
| flavor_id | None |
| ha | False |
| id | d9003cb6-8666-4473-b5eb-9ad0db2acf3e |
| interfaces_info | [{"subnet_id": "3bfbf912-bf48-4ac7-82d5-89c6d74b7952", "ip_address": "10.24.0.1", "port_id": "352ffe51-e491-454a-8b96-de827fc3230c"}] |
| name | router1 |
| project_id | 42040ac8030a43c29cdb4b5696208e49 |
| revision_number | None |
| routes | None |
| status | ACTIVE |
| tags | |
| updated_at | None |
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------+

And traceback log in Neutron API server: http://paste.openstack.org/show/714063/

Traceback (most recent call last):
  File "/opt/stack/openstack/neutron/neutron/api/v2/resource.py", line 98, in resource
    result = method(request=request, **args)
  File "/opt/stack/openstack/neutron/neutron/db/api.py", line 91, in wrapped
    setattr(e, '_RETRY_EXCEEDED', True)
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
    self.force_reraise()
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/openstack/neutron/neutron/db/api.py", line 87, in wrapped
    return f(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 147, in wrapper
    ectxt.value = e.inner_exc
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
    self.force_reraise()
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
    six.reraise(self.type_, self.value, self.tb)
  File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 135, in wrapper
    return f(*args, **kwargs)
  File "/opt/stack/openstack/neutron/neutron/db/api.py", line 126, in wrapped
    LOG.debug("Retry wrapper got retriable exception: %s", e)
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
    self.force_reraise()
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/openstack/neutron/neutron/db/api.py", line 122, in wrapped
    return f(*dup_args, **dup_kwargs)
  File "/opt/stack/openstack/neutron/neutron/api/v2/base.py", line 377, in show
    parent_id=parent_id),
  File "/opt/stack/openstack/neutron/neutron/api/v2/base.py", line 340, in _item
    obj = obj_getter(request.context, id, **kwargs)
  File "/opt/stack/contrail/openstack/neutron_plugin/neutron_plugin_contrail/plugins/opencontrail/contrail_plugin_base.py", line 500, in get_router
    return self._get_resource('router', context, router_id, fields)
  File "/opt/stack/contrail/openstack/neutron_plugin/neutron_plugin_contrail/plugins/opencontrail/contrail_plugin.py", line 325, in _get_resource
    fields=fields, obj_name=res_type)
  File "/opt/stack/contrail/openstack/neutron_plugin/neutron_plugin_contrail/plugins/opencontrail/contrail_plugin.py", line 291, in _transform_response
    plugin_base._raise_contrail_error(info, obj_name)
  File "/opt/stack/contrail/openstack/neutron_plugin/neutron_plugin_contrail/plugins/opencontrail/contrail_plugin_base.py", line 118, in _raise_contrail_error
    raise NeutronException(**info)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41075
Submitter: Édouard Thuleau (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41075
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/bd7cdb9242c2738062b8bd625c5dfab7f0c9b5ee
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit bd7cdb9242c2738062b8bd625c5dfab7f0c9b5ee
Author: Édouard Thuleau <email address hidden>
Date: Mon Mar 26 15:03:49 2018 +0200

Use L3 exceptions from neutron lib

Change-Id: I18e8fa15ee8d1fcc23dfa045ec43a1c18ca7c05c
Closes-Bug: #1758909