[CI updates] check_and_fail parameter not found in pacemaker_cluster ansible module

[Jose Luis Franco]

Updates process is failing in CI during the "overcloud update run Controller" step with the following error:

 u'fatal: [192.168.24.3]: FAILED! => {"ansible_job_id": "675770067420.74730", "changed": false, "finished": 1, "msg": "Unsupported parameters for (pacemaker_cluster) module: check_and_fail Supported parameters include: force,node,state,timeout"}'

The missing parameter is included in the redhat-openstack namespace version of the Ansible module: https://github.com/redhat-openstack/ansible-pacemaker/blob/master/modules/pacemaker_cluster.py#L38 but missing in the upstream version one: https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/clustering/pacemaker_cluster.py

Log with the error: https://logs.rdoproject.org/58/547058/10/openstack-check/gate-tripleo-ci-centos-7-multinode-1ctlr-featureset037-updates-master-nv/Z16336c778d3f415f8b3969f7b54757e0/undercloud/home/jenkins/overcloud_update_run_Controller.log.txt.gz

Logs to CI job: https://logs.rdoproject.org/58/547058/10/openstack-check/gate-tripleo-ci-centos-7-multinode-1ctlr-featureset037-updates-master-nv/Z16336c778d3f415f8b3969f7b54757e0/

[Jose Luis Franco (jfrancoa)]

The ansible-pacemaker module is usually installed during "undercloud upgrade" -> http://git.openstack.org/cgit/openstack/instack-undercloud/tree/instack_undercloud/undercloud.py#n2370 , however in upgrades/updates CI jobs we're using a mixed version deployment which misses the "undercloud upgrade" step, so at the time of updating the downstream ansible-pacemaker module is not found, and the upstream one is being taken from Ansible installation (ansible-pacemaker was included in ansible release 2.3).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556487
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=e2fbfae3edf632f897abb46d4e572a082ba1e76b
Submitter: Zuul
Branch: master

commit e2fbfae3edf632f897abb46d4e572a082ba1e76b
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Mar 26 13:11:28 2018 +0200

    Ensure ansible-pacemaker installation for updates/upgrades.

    The ansible-pacemaker module is needed in
    the undercloud to run some of the updates/upgrades
    tasks. It's generaly installed during 'undercloud
    upgrade' step, but as in CI we're using a mixed
    version deployment the 'undercloud upgrade' step
    is being skipped.

    Change-Id: I0c8a36a06bc0f078031fafbafbbdee923a459339
    Closes-Bug: #1758880

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/561571

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561571
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=115105f2e9fa8757cf21622250d52fa092b5f3a6
Submitter: Zuul
Branch: stable/queens

commit 115105f2e9fa8757cf21622250d52fa092b5f3a6
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Mar 26 13:11:28 2018 +0200

    Ensure ansible-pacemaker installation for updates/upgrades.

    The ansible-pacemaker module is needed in
    the undercloud to run some of the updates/upgrades
    tasks. It's generaly installed during 'undercloud
    upgrade' step, but as in CI we're using a mixed
    version deployment the 'undercloud upgrade' step
    is being skipped.

    Change-Id: I0c8a36a06bc0f078031fafbafbbdee923a459339
    Closes-Bug: #1758880
    (cherry picked from commit e2fbfae3edf632f897abb46d4e572a082ba1e76b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-upgrade 3.0.0 release.