Deere: Overlapping in effect region at minimum width

Bug #1758174 reported by Daniel Schürmann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
ronso0

Bug Description

see screenshot

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Revision history for this message
Be (be.ing) wrote :

This only happens when:
1. An effect with lots of parameters is loaded
2. Parameters are showing for that effect unit
3. The window is at the minimum width

I don't see any way around this other than making the effect parameter knobs and labels tiny.

Changed in mixxx:
status: New → Confirmed
summary: - Deere: Overlapping in effect region
+ Deere: Overlapping in effect region at minimum width
Revision history for this message
ronso0 (ronso0) wrote :

or give parameter names, link & link invert buttons a
- minimum size (knob width + x)
- maximum size (current fixed size)
- size policy min
and do the same for effect selector (size policy me)

This way everything would look like it does now on big screens, on small screens labels, link buttons & effect selector can shrink but the overlapping would be gone.

Revision history for this message
Be (be.ing) wrote :

Yes, that would be the ideal solution. But our skin system is not smart enough to implement such responsive designs. There is the SizeAwareStack widget, but I don't think that's a great solution. I think this is an example where QML could be really helpful. With QML, I think it would be fairly easy to conditionally define the dimensions of the knob widgets to take into account the available space.

I think WEffectSelector must be a fixed size because Qt does not take into account the width of the text for the items it contains when determining how to size it dynamically.

Revision history for this message
ronso0 (ronso0) wrote :

it works in LateNight. no SizeAwareStack, just <Min>, <Max> and <SizePolicy>

Revision history for this message
Be (be.ing) wrote :

Okay, if you'd like to try fixing this in Deere for 2.1, please do.

Revision history for this message
ronso0 (ronso0) wrote :

If I need some distraction from work, I'll try.
not sure that I'll have the time to make it look super nice, but it can work for the extreme cases.

Changed in mixxx:
assignee: nobody → ronso0 (medontknow)
Revision history for this message
ronso0 (ronso0) wrote :

I can do this the day after tomorrow.
Is there an agreed release date?

Be (be.ing)
Changed in mixxx:
milestone: none → 2.1.0
importance: Undecided → Low
Be (be.ing)
Changed in mixxx:
status: Confirmed → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9187

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.