src/mongo/db/fts/unicode is not optimised on ppc64el
Bug #1758118 reported by
Robie Basak
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
mongodb (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I'm about to regress performance in mongodb on ppc64el by using the non-optimised path to fix bug 1758116, so am opening this bug to track the consequent performance regression.
When https:/
tags: | added: ppc64el |
tags: | added: architecture-ppc64le bugnameltc-166135 severity-medium targetmilestone-inin--- |
tags: |
added: targetmilestone-inin18043 removed: targetmilestone-inin--- |
To post a comment you must log in.
I'm wary of the suggested change in the upstream bug report:
- return vec_extract( vec_vbpermq( _data, bits), 0); vec_vbpermq( _data, bits), 1);
+ return vec_extract(
It's useful to know if this fixes the problem, and I can confirm that it does. But without knowing _why_ this fixes the issue, it isn't clear to me that this is a correct fix, and so I did not include it. Since otherwise that'd suggest a significant behaviour change from older gcc, and I haven't found a relevant compiler bug report that indicates that this is the case.
I'd appreciate someone who understands the ISA and compiler behaviour to verify what the correct fix should be, advocate that upstream and get it landed. Then we can cherry-pick that fix easily enough and re-enable the ppc64el optimisation path.