periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027-master fails with undefined groups.overcloud

[Bogdan Dobrelya]

periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027 has been switched [0] to deploy containerized UC, and that part works fine. Though it can't finish the overcloud deployment because of the undefined overcloud group , see https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027-master/836af96/console.txt.gz#_2018-03-21_15_10_32_513

This blocks adding the subject CI job into the promotion pipeline [1], which is a critical issue for rocky dev cycle m1 AFAICT.

The code that fails is [2] (and potentially [3] needs to be fixed as well?)

[0] https://review.rdoproject.org/r/#/c/12770/
[1] https://review.rdoproject.org/r/#/c/12774/
[2] http://git.openstack.org/cgit/openstack/tripleo-quickstart/tree/config/nodes/1ctlr.yml
[3] http://git.openstack.org/cgit/openstack/tripleo-quickstart/tree/config/nodes/2ctlr.yml

[Bogdan Dobrelya (bogdando)]

The error message https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027-master/836af96/console.txt.gz#_2018-03-21_14_40_37_598
seems related to the empty overcloud group. Is that open bug also related https://github.com/ansible/ansible/issues/35255 ?..

[Bogdan Dobrelya (bogdando)]

The breaking change is potentially https://review.openstack.org/#/c/531503/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/555232

[wes hayutin (weshayutin)]

Thanks for the fix Arx!

Featureset027 is not required to promote yet, so removing it as a blocker
https://github.com/rdo-infra/ci-config/blob/master/ci-scripts/dlrnapi_promoter/config/master.ini#L15-L24

[wes hayutin (weshayutin)]

geez.. sorry.. it is gating.. updating promotion requirements now

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/555232
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=73d0427f38fd39752dc75de61c7da53f6e5fea52
Submitter: Zuul
Branch: master

commit 73d0427f38fd39752dc75de61c7da53f6e5fea52
Author: Arx Cruz <email address hidden>
Date: Thu Mar 22 11:00:29 2018 +0100

    Checking if the overcloud group is empty

    The hostnamemap_override fact is failing in featureset027 because the
    group overcloud is empty, and hostnamemap_override forces to access the
    first object from this group. This patch add one more verification
    before setting the fact.

    Change-Id: Ibe459b3200d8eaeb93171955f16dbb64dc077a33
    Closes-Bug: 1757474

[Bogdan Dobrelya (bogdando)]

The periodic job failed with the patch in place https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027-master/59cde6b/console.txt.gz#_2018-03-23_06_03_04_318

We need to check if the group is not only define, but is not empty as well

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/555703

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/555703
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=9579af5ac85543cd8324ca2862fc93fc8c6880d5
Submitter: Zuul
Branch: master

commit 9579af5ac85543cd8324ca2862fc93fc8c6880d5
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Mar 23 09:57:05 2018 +0100

    Fix checking if the overcloud group is empty

    The hostnamemap_override fact is failing in featureset027 because the
    group overcloud is empty, and hostnamemap_override forces to access the
    first object from this group. This patch add one more verification
    for the overcloud group to contain at least one member.

    Closes-Bug: 1757474

    Change-Id: I485e555bb56b7548a27c8638784bf01b430be463
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[Arx Cruz (arxcruz)]

Still failing, perhaps we need a different approach...

https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset027-master/a34c536/console.txt.gz#_2018-03-26_01_38_27_697

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556423

[Bogdan Dobrelya (bogdando)]

Arz Cruz, the approach is correct, we just missed another place to fix

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556463

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556463
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=ffecd43bd736188a868020f8fe54795c3d8b899e
Submitter: Zuul
Branch: master

commit ffecd43bd736188a868020f8fe54795c3d8b899e
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Mar 26 11:37:29 2018 +0200

    Fix checking if the overcloud group is empty

    The hostnamemap_override fact is failing in featureset027 because the
    group overcloud is empty, and hostnamemap_override forces to access the
    first object from this group. This patch add **one more** verification
    for the overcloud group to contain at least one member.

    Closes-Bug: #1757474

    Change-Id: Ibfd73277cb93cdb26b6598f45e7f82e31897d2a4
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Change abandoned by Arx Cruz (<email address hidden>) on branch: master
Review: https://review.openstack.org/556423

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.