undercloud_deploy.py missing unit tests

[Jill Rouleau]

Ansible-related functions lack unit tests, making it easy to miss breaking changes early in the dev cycle. Test coverage should be added for DeployUndercloud._download_ansible_playbooks, DeployUndercloud._launch_ansible, and DeployUndercloud.take_action. Tests should expose the breakage introduced by https://review.openstack.org/#/c/550577/2 for example.

http://logs.openstack.org/77/550577/2/check/tripleo-ci-centos-7-undercloud-containers/5997ba5/logs/undercloud/home/zuul/undercloud_install.log.txt.gz
2018-03-16 21:27:46 | ['Traceback (most recent call last):\n', ' File "/usr/lib/python2.7/site-packages/tripleoclient/v1/undercloud_deploy.py", line 582, in take_action\n parsed_args.output_dir)\n', ' File "/usr/lib/python2.7/site-packages/tripleoclient/v1/undercloud_deploy.py", line 415, in _download_ansible_playbooks\n key=os.path.getctime)\n', 'ValueError: max() arg is an empty sequence\n']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/555456

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/555456
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=11a4adb0abf4249c18dbd4db19a040de9e9f66be
Submitter: Zuul
Branch: master

commit 11a4adb0abf4249c18dbd4db19a040de9e9f66be
Author: Jill Rouleau <email address hidden>
Date: Wed Mar 21 15:17:16 2018 -0700

    Add missing unit tests for undercloud_deploy

    Change-Id: I6fd8291fb5fec590ec0e96f33ac00d553b2fac16
    Closes-Bug: 1757230

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.0.0 release.