OpenStack Dashboard (Horizon)

Uploading OVA to Glance via Horizon Fails

Bug #1757136 reported by Guillaume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Guillaume

Bug Description

Same bug as https://bugs.launchpad.net/horizon/+bug/1641383.

openstack_dashboard/api/rest/glance.py does not handle 'ova' disk_format.
Because there is 2 implementation of create_image_metadata,
one for Django view implementation and one for angular REST call.

See original description
Guillaume (vatlas)
Changed in horizon:
assignee: nobody → Guillaume (vatlas)
Revision history for this message
Guillaume (vatlas) wrote :

fix: https://review.openstack.org/#/c/554572/1

description: updated
OpenStack Infra (hudson-openstack)
Changed in horizon:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Guillaume (vatlas) → Akihiro Motoki (amotoki)
OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Akihiro Motoki (amotoki) → Guillaume (vatlas)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/554572
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3626260313c87aba6d9579c81f8dac415cc7235
Submitter: Zuul
Branch: master

commit e3626260313c87aba6d9579c81f8dac415cc7235
Author: Guillaume Le Blanc <email address hidden>
Date: Tue Mar 20 14:51:46 2018 +0100

    Allow OVA upload for images

    Bug #1641383 was not fixed for REST API call.
    The two implementation of create_image_metadata are merged
    into api/glance.py.

    There were minor differences in field naming and handling
    (min_ vs minimum_, is_public vs public vs visibility).
    This commit normalizes them to simplify the logic.

    Closes-Bug: #1757136
    Change-Id: I41e9d94345151bc4473d704cdc040ed77870ce45

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/566267

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/queens)

Reviewed: https://review.openstack.org/566267
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e41a54d4b6280d937ed4037e47c74c5b1f566871
Submitter: Zuul
Branch: stable/queens

commit e41a54d4b6280d937ed4037e47c74c5b1f566871
Author: Guillaume Le Blanc <email address hidden>
Date: Tue Mar 20 14:51:46 2018 +0100

    Allow OVA upload for images

    Bug #1641383 was not fixed for REST API call.
    The two implementation of create_image_metadata are merged
    into api/glance.py.

    There were minor differences in field naming and handling
    (min_ vs minimum_, is_public vs public vs visibility).
    This commit normalizes them to simplify the logic.

    Closes-Bug: #1757136
    Change-Id: I41e9d94345151bc4473d704cdc040ed77870ce45
    (cherry picked from commit e3626260313c87aba6d9579c81f8dac415cc7235)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b2

This issue was fixed in the openstack/horizon 14.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.2

This issue was fixed in the openstack/horizon 13.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/725785

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/pike)

Change abandoned by "Radomir Dopieralski <email address hidden>" on branch: stable/pike
Review: https://review.opendev.org/c/openstack/horizon/+/725785
Reason: Since pike is going end-of-life, we will not merge this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.