OpenStack Dashboard (Horizon)

wrong variable name in context_processors.py

Bug #1757112 reported by Adrian Turjak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Adrian Turjak

Bug Description

In the patch that added user menu links, the variable name for disabling v2 rc files was renamed by accident it seems in the context_processors.py module.

https://github.com/openstack/horizon/commit/924239073ec8036265d13a3c6b09d6fa7865147f#diff-5a128d55603c030b687d1321df381ab0L100
vs
https://github.com/openstack/horizon/commit/924239073ec8036265d13a3c6b09d6fa7865147f#diff-5a128d55603c030b687d1321df381ab0R91

Because of that the v2 download in the user dropdown wasn't being hidden correctly. The fix is easy.

OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: nobody → Adrian Turjak (adriant-y)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/554413
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f588b4ee2e73c754a7565928c47552e159a1666d
Submitter: Zuul
Branch: master

commit f588b4ee2e73c754a7565928c47552e159a1666d
Author: Adrian Turjak <email address hidden>
Date: Tue Mar 20 17:55:52 2018 +1300

    Fix wrong setting name for SHOW_KEYSTONE_V2_RC

    The user links patch didn't use the same setting
    variable name in context_processors.py, this fixes
    that.

    Closes-Bug: #1757112

    Change-Id: Ie0e516d82c2c1cdc1c343075393cdf9c336f8e5f

Changed in horizon:
status: In Progress → Fix Released
Akihiro Motoki (amotoki)
tags: added: queens-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/554998

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b1

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/queens)

Reviewed: https://review.openstack.org/554998
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=dd23dadd450a38390fe534b406a0d134b4571ab3
Submitter: Zuul
Branch: stable/queens

commit dd23dadd450a38390fe534b406a0d134b4571ab3
Author: Adrian Turjak <email address hidden>
Date: Tue Mar 20 17:55:52 2018 +1300

    Fix wrong setting name for SHOW_KEYSTONE_V2_RC

    The user links patch didn't use the same setting
    variable name in context_processors.py, this fixes
    that.

    Closes-Bug: #1757112

    Change-Id: Ie0e516d82c2c1cdc1c343075393cdf9c336f8e5f
    (cherry picked from commit f588b4ee2e73c754a7565928c47552e159a1666d)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.1

This issue was fixed in the openstack/horizon 13.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.