containers build job fails due to jinja evaluation of test_ping|bool

[wes hayutin]

19:31:00 TASK [validate-simple : Old THT workaround, check for pingtest template] *******
19:31:00 Monday 19 March 2018 19:31:00 +0000 (0:00:00.155) 0:00:00.155 **********
19:31:00 fatal: [undercloud]: FAILED! => {"failed": true, "msg": "The conditional check 'test_ping|bool' failed. The error was: error while evaluating conditional (test_ping|bool): 'test_ping' is undefined\n\nThe error appears to have been in '/home/jenkins/workspace/periodic-tripleo-centos-7-queens-containers-build/.quickstart/usr/local/share/ansible/roles/validate-simple/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Old THT workaround, check for pingtest template\n ^ here\n"}

https://review.rdoproject.org/jenkins/job/periodic-tripleo-centos-7-queens-containers-build/95/console

Introduced in https://review.openstack.org/#/c/551983/

This is causing the prod chain tripleo promote jobs to fail

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/554367

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554367
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=1f93cee83abae3ebd337f64df3f3f7ed41bba379
Submitter: Zuul
Branch: master

commit 1f93cee83abae3ebd337f64df3f3f7ed41bba379
Author: Wes Hayutin <email address hidden>
Date: Mon Mar 19 18:05:15 2018 -0400

    move test_ping variable to extras/common

    test_ping is being referenced outside of
    the overcloud deployment.

    Closes-Bug: #1757005
    Change-Id: I3eda58a33854d8fd7c9a1147e28b19dd22c3d647

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/554519

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554519
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=e150e2b06d57c625e275de0c779272c979bd2c70
Submitter: Zuul
Branch: master

commit e150e2b06d57c625e275de0c779272c979bd2c70
Author: Wes Hayutin <email address hidden>
Date: Tue Mar 20 08:08:39 2018 -0400

    turn off ping/tempest in fs023

    Closes-Bug: #1757005
    Change-Id: I53cd1a937a05f15376a2613fb57a97b324289294

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.