crash when adding rng device to live vm

[Andreas Hasenack]

virt-manager is crashing when I add an RNG device to a VM that is running. As soon as I click the last button, the vm info window disappears and the virt-manager main window loses all its instances and remains unresponsive. Clicking on the "x" doesn't close it. I have to go to the terminal and run "killall virt-manager".

I didn't verify if this happens when adding another type of device.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: virt-manager 1:1.5.0-0ubuntu1
ProcVersionSignature: Ubuntu 4.15.0-12.13-generic 4.15.7
Uname: Linux 4.15.0-12-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.8-0ubuntu10
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Mar 19 16:20:26 2018
PackageArchitecture: all
SourcePackage: virt-manager
UpgradeStatus: No upgrade log present (probably fresh install)

[Christian Ehrhardt  (paelzer)]

IRC: we checked and the pid is changing on this, which means libvirtd crashes.
=> maybe bug 1756915

I provided an untested ppa to try for now.

Please make it a dup if it helps.
If it doesn't fix it update it here and I'll take a look tmrw.

[Christian Ehrhardt  (paelzer)]

I'll ping here once my proposed ppa is working for my cases, so that you can retry then again.

[Christian Ehrhardt  (paelzer)]

ubuntu@node-horsea:~$ cat hotplug-rng.xml
<rng model='virtio'>
        <rate period="2000" bytes="1234"/>
        <backend model='random'>/dev/random</backend>
</rng>

sudo virsh attach-device xenial-testshutdown-0 hotplug-rng.xml --live
error: Disconnected from qemu:///system due to end of file
error: Failed to attach device from hotplug-rng.xml
error: End of file while reading data: Input/output error

[1706255.353956] libvirtd[9901]: segfault at 0 ip 00007f688060a020 sp 00007f6872c89968 error 4 in libvirt.so.0.4000.0[7f68804f8000+3be000]

It is the same issue, dup'ing