tripleo

Introspection reports success even if no nodes were introspected

Bug #1756855 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Dmitry Tantsur
tripleo rocky-1

Bug Description

Subj. may be confusing, as it may be due to e.g. all nodes being at fault or "available". We should error out if no nodes went to introspection.

Initially reported as https://bugzilla.redhat.com/show_bug.cgi?id=1551790

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/554204

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.openstack.org/554204
Reason: should be done in workflows

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/554213

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/554213
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=405c6b2b83336d5432e9e47df3f182902a632530
Submitter: Zuul
Branch: master

commit 405c6b2b83336d5432e9e47df3f182902a632530
Author: Dmitry Tantsur <email address hidden>
Date: Mon Mar 19 13:30:10 2018 +0100

    Fail introspect_manageable_nodes if no nodes are manageable

    Operators running this workflow usually expect it to do something,
    while currently we report success if nothing is done.

    Also include node count in the success message and remove its duplicate.

    Closes-Bug: #1756855
    Change-Id: I88cf92a8c9a06eb492bdd2729754da4ff9d86d74

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/555287

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.openstack.org/555287
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9a856a0532b6212a61d80192bd495b35f7804310
Submitter: Zuul
Branch: stable/queens

commit 9a856a0532b6212a61d80192bd495b35f7804310
Author: Dmitry Tantsur <email address hidden>
Date: Mon Mar 19 13:30:10 2018 +0100

    Fail introspect_manageable_nodes if no nodes are manageable

    Operators running this workflow usually expect it to do something,
    while currently we report success if nothing is done.

    Also include node count in the success message and remove its duplicate.

    Closes-Bug: #1756855
    Change-Id: I88cf92a8c9a06eb492bdd2729754da4ff9d86d74
    (cherry picked from commit 405c6b2b83336d5432e9e47df3f182902a632530)

tags: added: in-stable-queens
Dmitry Tantsur (divius)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.0.0

This issue was fixed in the openstack/tripleo-common 9.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.6.1

This issue was fixed in the openstack/tripleo-common 8.6.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.