contrast between link and non-link text in webstaff grids

[Galen Charlton]

As a result of the patch for bug 1746365, the contrast between the new link color and the background of selected rows in grids is now 4.71:1, achieving compliance WCAG 2.0 AA guidelines.

However, the color of non-link text (#333) and link text (#286090) has a contrast ratio of only 1.90:1, meaning that we're not achieving the 3:1 ratio suggested when doing nothing else to distinguish link text from non-link text (see https://webaim.org/blog/wcag-2-0-and-link-colors/).

Evergreen master

[Galen Charlton (gmc)]

(In retrospect, I think I may have jumped the gun on merging bug 1746365).

Anyway, changing the non-link text color to #000 (black) in grid cells would bring the contrast to 3.17:1, which meets the suggested ratio. (And looking at it more, changing the default text color from Bootstrap's default of #333 to #000 across the board might be a good idea in general).

The branch user/gmcharlt/lp1756572_wip has a change that does some of this as a discussion piece; it also adds underlines for links inside grid contents.

[Kathy Lussier (klussier)]

I this this looks good. I generally like underlined links because it's more clear to the user that they are links. I can add a signoff, but were you looking to get more feedback before merging?

[Galen Charlton (gmc)]

On reflection, I think the patch can be signed off as is; while there are other places in the default Bootstrap CSS where text defaults to #333, e.g., in buttons, the patch as is offers an improvement.

[Kathy Lussier (klussier)]

Thanks Galen! I've merged the improvement to master, release 3.0 and 2.12.