5.0: Granular Routing policy. Some legacy routing policy terms do not work

[Shashikiran H]

Version: 5.0
Picked up the latest build.

Topo:
10.204.217.7 cfgm control ui openstack
10.204.216.68 cfgm control
10.204.216.72 cfgm control
10.204.217.16 vrouter
10.204.217.17 vrouter

left-vn --- si1(ecmp, in-network) --- si2(ecmp, nat) --- right-vn

I am trying to match based on legacy routing policy terms. I have created 1754263 for BGP based match not working. Even static, xmpp and service-chain do not work for me. Please clarify the usecases for these match conditions or we have to release note that these no longer work and possibly remove these options.
Aggregate is the only match condition that works from legacy cases currently.
<iq>
 <routing-policy-entries>
  <term>
   <term-match-condition>
    <protocol>service-chain</protocol>
    <community></community>
    <community-match-all>false</community-match-all>
   </term-match-condition>
   <term-action-list>
    <update>
     <as-path>
      <expand />
     </as-path>
     <community>
      <add />
      <remove />
      <set />
     </community>
     <local-pref>0</local-pref>
     <med>312</med>
    </update>
    <action></action>
   </term-action-list>
  </term>
 </routing-policy-entries>
</iq>

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41278
Submitter: Nikhil Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41278
Committed: http://github.com/Juniper/contrail-controller/commit/025cd84e5807197f80225315108948c9c89afbe3
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 025cd84e5807197f80225315108948c9c89afbe3
Author: Nikhil Bansal <email address hidden>
Date: Mon Apr 2 08:05:11 2018 +0530

Policy match was not matching subprotocol correctly

If matching protocol is subprotocol, then match function should compare
it with corresponding value in attributes. Otherwise, match with path
protocol as it was done earlier.
Also need to retain subprotocol value in re-originated routes since
there can be a use case to match on subprotocol for reoriginated
routes. Will have to modify spec accordingly.

Change-Id: Idbbf3e216dfa6cf2fd0e298a451125750613ab83
Closes-Bug: #1756498

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41443
Submitter: Nikhil Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41443
Committed: http://github.com/Juniper/contrail-controller/commit/281da93893e7442958a77e0863c6ecad0a482ab9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 281da93893e7442958a77e0863c6ecad0a482ab9
Author: Nikhil Bansal <email address hidden>
Date: Mon Apr 2 08:05:11 2018 +0530

Policy match was not matching subprotocol correctly

If matching protocol is subprotocol, then match function should compare
it with corresponding value in attributes. Otherwise, match with path
protocol as it was done earlier.
Also need to retain subprotocol value in re-originated routes since
there can be a use case to match on subprotocol for reoriginated
routes. Will have to modify spec accordingly.

Change-Id: Idbbf3e216dfa6cf2fd0e298a451125750613ab83
Closes-Bug: #1756498
(cherry picked from commit 025cd84e5807197f80225315108948c9c89afbe3)