Masquerade networks in CI moving to quickstart

[Emilien Macchi]

Some efforts are made to port the routed networks support from instack-undercloud to python-tripleoclient and tripleo-heat-templates so we can use this feature when the undercloud is containerized.

Some work in progress is being done:
https://review.openstack.org/#/c/543455/
https://review.openstack.org/#/c/553427/

(and more: https://review.openstack.org/#/q/topic:containers-routed-spine-leaf+(status:open+OR+status:merged)

Until we finish the feature, we need to have some workaround in CI so we can deploy a basic IPtables rule for masquerading and get OVB networking working in our CI environment.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/553620

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553620
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=e47d68eb11d3c2a1360c9018b6a47f05e874ecbc
Submitter: Zuul
Branch: master

commit e47d68eb11d3c2a1360c9018b6a47f05e874ecbc
Author: Emilien Macchi <email address hidden>
Date: Thu Mar 15 22:43:21 2018 +0100

    undercloud: workaround for masquerading network in CI/OVB

    Full context: https://bugs.launchpad.net/tripleo/+bug/1756183

    This code aims to:
    - configure basic masquerade network iptables rules
    - be temporary until routed networks is properly ported in
      tripleoclient.
    - be technical debt and will be cleanup as soon as possible.

    Co-authored-by: Bogdan Dobrelya <email address hidden>
    Change-Id: Ic8c9c6d3f30d9a37a0b3e0904c1bc7a6b35b32a3
    Related-Bug: #1756183

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/557851

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557851
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=3605f546f2e602a3ba775fb90119da199f49691e
Submitter: Zuul
Branch: master

commit 3605f546f2e602a3ba775fb90119da199f49691e
Author: Emilien Macchi <email address hidden>
Date: Fri Mar 30 08:56:24 2018 -0700

    Remove nat/masquerading config workarounds.

    1) This reverts commit e47d68eb11d3c2a1360c9018b6a47f05e874ecbc.
       That was technical debt, and with the new service in THT we don't need
       it anymore in Rocky.

    2) This removes undercloud_external_network_cidr rule that shouldn't be
       useful since we control in THT for Rocky.

    Closes-Bug: #1756183
    Change-Id: I39b04f81803d76e419d1f3960edc4c927b2dbd4e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.