dashboard:make the image min_disk and min_ram valule empty,error report after user update image ,not before

Bug #1755958 reported by wangxiaoxian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
pengyuesheng

Bug Description

The Dashboard UI Bug :
dashboard->Project->Compute->Image->Edit mirror.Then make the Minimum Disk and Minimum RAM value null.we can also click the "Update Image".we will get the inf "Error:Unable to update the image".The UI should check the empty value and give the errors to inform the user of a problem.

The Compare:
If we give the "Minimum Disk" and "Minimum RAM" an invalid value,the UI will give user the hint about invalid value normally and the "Update Image" can't be clicked as usual.

Revision history for this message
wangxiaoxian (wangxiaoxian) wrote :
Revision history for this message
wangxiaoxian (wangxiaoxian) wrote :

In fact,in the Chinese interface,after clicking "update mirror",it shows "can't delete the mirror".

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/561115

Changed in horizon:
assignee: nobody → pengyuesheng (pengyuesheng)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/561115
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f843b6389f9bc8bb67d59adbb22a97544bad0e75
Submitter: Zuul
Branch: master

commit f843b6389f9bc8bb67d59adbb22a97544bad0e75
Author: pengyuesheng <email address hidden>
Date: Fri Apr 13 11:29:09 2018 +0800

    Make fields in image edit required

    Make the min_disk and min_ram fields in the image edit form required,
    so that the form can't be submitted with empty values for those fields,
    which always results in an error.

    Change-Id: I5a3fdb74f127ed1d084ac7b47dfd6e0d8b076a1c
    Closes-Bug: #1755958

Changed in horizon:
status: In Progress → Fix Released
Akihiro Motoki (amotoki)
Changed in horizon:
importance: Undecided → High
milestone: none → stein-1
tags: removed: check empty value
tags: added: rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0b1

This issue was fixed in the openstack/horizon 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.