tripleo

dlrn baseurl might be badly evaluated from the dlrn_hash_path fact when reusing dirty working_dir

Bug #1755766 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Won't Fix
High
Unassigned
tripleo rocky-1

Bug Description

When dlrn_hash_path fact is evaluated http://git.openstack.org/cgit/openstack/tripleo-quickstart/tree/roles/repo-setup/tasks/get-dlrn-hash.yml#n55 it might end up in a bad substitution for the repo_setup.sh, like "cu/rr/current-tripleo-rdo". That affects at very least all of the config/releases files.

I'm not sure if there are valid cases for the dlrn_hash_path fact evaluated from dlrn_hash in that way though, but at very least would be nice to clarify in docs the allowed values/formats of dlrn_hash?

See original description
Tags: ci quickstart ux
Bogdan Dobrelya (bogdando)
tags: added: ci quickstart
Changed in tripleo:
importance: Undecided → High
status: New → Triaged
milestone: none → rocky-1
Bogdan Dobrelya (bogdando)
summary: - dlrn baseurl is badly evaluated for undefined dlrn_hash_path fact
+ dlrn baseurl might be badly evaluated from the dlrn_hash_path fact
description: updated
Revision history for this message
Bogdan Dobrelya (bogdando) wrote : Re: dlrn baseurl might be badly evaluated from the dlrn_hash_path fact

That may be the dirty ansible facts cache issue

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

I can still reproduce that with a purged facts cache. I believe the bug falls into undocumented nuances of dlrn_hash - when it can/should be put as words, like current-tripleo, and when as a hash, like 35414701c176a6288fc2ad141dad0f73624dcb94_43527485 .

tags: added: ux
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

With my workin_dir changed to not keep any dirty state, this is not an issue anymore

summary: - dlrn baseurl might be badly evaluated from the dlrn_hash_path fact
+ dlrn baseurl might be badly evaluated from the dlrn_hash_path fact when
+ reusing dirty working_dir
Changed in tripleo:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.