Not all references of 'auth_uri' have been removed from openstack projects when we deprecated 'auth_uri' to bring 'www_authenticate_uri'

Bug #1755728 reported by Abhishek Sharma M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Unassigned
keystonemiddleware
Triaged
Medium
Unassigned

Bug Description

As part of https://review.openstack.org/#/c/508522/, we replaced 'auth_uri' middleware parameter with 'www_authenticate_uri' parameter to avoid confusion between 'auth_uri' & 'auth_url' parameters.

However, the changes were made just in openstack/keystonemiddleware project & all the other references to 'auth_uri' in other openstack projects were not taken care of.

We are concerned that if we switch to 'www_authenticate_uri' parameter in our [keystone_authtoken] section, these 'auth_uri' references might create problems. So, it will be better if community completely gets rid of 'auth_uri'.

Some of the files in which I could find 'auth_uri' references are below:

https://github.com/openstack/cinder/blob/master/cinder/quota_utils.py
https://github.com/openstack/cinder/blob/master/cinder/tests/unit/api/contrib/test_quotas.py
https://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/drivers/nexenta/test_nexenta5_jsonrpc.py
https://github.com/openstack/cinder/blob/master/cinder/tests/unit/conf_fixture.py
https://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_quota_utils.py
https://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_quota.py
https://github.com/openstack/cinder/blob/master/cinder/tests/functional/api/client.py
https://github.com/openstack/nova/blob/stable/queens/nova/tests/functional/api/client.py
https://github.com/openstack/nova/blob/stable/queens/nova/tests/unit/api/openstack/placement/test_deploy.py

Apart from these also grep for 'auth_uri' in mistralclient & networking_infoblox prjects.
Not all files would require the change as some of them just use auth_uri as variable name. I am not sure if this needs to be taken care by keystonemiddleware team or respective project teams, as of now assigning to keystonemiddleware. Please change accordingly.

Revision history for this message
wangxiyuan (wangxiyuan) wrote :

yeah, it's a good reminder. The projects who use keystonemiddleware should pay attention.

After checking Cinder code, I think it's a wrong usage. Cinder should use auth_url, not auth_uri.

Revision history for this message
Lance Bragstad (lbragstad) wrote :

It might help to associate projects that need assistance moving to www_authenticate_uri to this bug report.

Changed in keystonemiddleware:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
wangxiyuan (wangxiyuan) wrote :
Changed in cinder:
status: New → Fix Released
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Looks like there are other projects still relying on auth_uri [0]. Keeping this open since it's a relatively good low-hanging-fruit bug and something we should try and correct in other services.

[0] http://codesearch.openstack.org/?q=auth_uri&i=nope&files=&repos=

tags: added: low
tags: added: low-hanging-fruit
removed: low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.