rdo2: all BM jobs are not able to be hand edited, JJB contains deprecated element

[Matt Young]

Found while debugging other issues...

The Bare metal jobs that run in RDO Phase 2 have an issue presently where if a hand edit is made to a job (to test a patch for example) the following occurs:

- the dlrnapi post build task is nuked/deleted
- the collect logs post build task is duplicated

I suspect this is because these jobs have the following post-build tasks defined (order matters):

1. collect logs
2. groovy post build (deprecated and needs to go)
3. dlrnapi results (if pass)
4. dlrnapi results (if fail)

the groovy postbuild publisher (jjb noun), #2, is not a currently supported JJB element, in jenkins 2.x, but the jjb push jobs are still using jenkins-jobs v1.6. hypothesis: this is causing the error because while the jjb push works and creates the job definition, it causes an error in the front end stack when attempting to persist the job definition. other jobs in rdo2 that are not BM do use this publisher, but it's the last item on the list.

This is a working theory...next steps are to remove the groovy postbuild publisher (which needs to happen anyway), as our JJB won't compile with current jenkins-jobs tool.

[Matt Young (halcyondude)]

Note from JJB docs:

https://docs.openstack.org/infra/jenkins-job-builder/publishers.html#publishers.groovy-postbuild

```
Please pay attention on version of plugin you have installed. There were incompatible changes between 1.x and 2.x. Please see home page of this plugin for full information including migration process.
```

[Matt Young (halcyondude)]

Presently we're running v2.40, with 2.41 update pending

[Matt Young (halcyondude)]

I have replicated the issue on a personal jenkins server and posted a fix to internal JJB (used for rdo2)

The older 1.6 jenkins-jobs utility pushing JJB was the cause of the error. Fixing the JJB (which enables using the current jenkins-jobs utility) resolves the issue.

[Matt Young (halcyondude)]

https://{rhinternal}/gerrit/#/c/132825/

[Matt Young (halcyondude)]

https://{rhinternal}/gerrit/gitweb?p=tripleo-environments.git;a=commit;h=9c73b12da75ef3ce3018b271f2b4d7398c593977