Undercloud Installation is failing in periodic promotion jobs after new openstacksdk release

[yatin]

Undercloud installation failing with ERROR:-
2018-03-10 04:48:38 | 2018-03-10 04:48:38,450 INFO: Network create/update failed get_session_client() got an unexpected keyword argument 'constructor'
2018-03-10 04:48:38 | 2018-03-10 04:48:38,450 DEBUG: An exception occurred
2018-03-10 04:48:38 | Traceback (most recent call last):
2018-03-10 04:48:38 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 2324, in install
2018-03-10 04:48:38 | _post_config(instack_env, upgrade)
2018-03-10 04:48:38 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1989, in _post_config
2018-03-10 04:48:38 | network = _ensure_neutron_network(sdk)
2018-03-10 04:48:38 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 2034, in _ensure_neutron_network
2018-03-10 04:48:38 | network = list(sdk.network.networks(name=PHYSICAL_NETWORK))
2018-03-10 04:48:38 | File "/usr/lib/python2.7/site-packages/openstack/service_description.py", line 95, in __get__
2018-03-10 04:48:38 | allow_version_hack=True,
2018-03-10 04:48:38 | TypeError: get_session_client() got an unexpected keyword argument 'constructor'
2018-03-10 04:48:38 | 2018-03-10 04:48:38,451 ERROR:

Failure logs:-
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-centos-7-master-containers-build/84776b9/undercloud/home/jenkins/undercloud_install.log.txt.gz#_2018-03-13_09_43_04
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-centos-7-master-containers-build/7ab45da/undercloud/home/jenkins/undercloud_install.log.txt.gz#_2018-03-10_09_51_14

Last undercloud installation completed with openstacksdk 0.11.3:-
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-centos-7-master-containers-build/ea065a9/undercloud/home/jenkins/undercloud_install.log.txt.gz

New openstacksdk release is 0.12.0(previous was 0.11.3):-https://review.rdoproject.org/r/#/c/12817/2/rdo.yml

Looks like get_session_client is used from os_client_config https://github.com/openstack/os-client-config/blob/master/os_client_config/cloud_config.py#L260 while "constructor" argument is defined in openstacksdk: https://github.com/openstack/python-openstacksdk/blob/e7b58ce7d76368632cf2fc05e41a3aca50cec20c/openstack/config/cloud_region.py#L309-L311

So looks like after new release there is some interface change.

Related Review: https://review.openstack.org/#/c/549307/

[John Trowbridge (trown)]

That review for os-client-config will require a packaging change, since it changes the requirements[1]. I am trying to setup up a reproducer on master with that change, but dlrn fails to build the package because the unit tests require openstacksdk with that change and we dont have it in the Build-Requires[2].

[1]https://review.openstack.org/#/c/549307/3/requirements.txt
[2]https://review.rdoproject.org/r/gitweb?p=openstack/os-client-config-distgit.git;a=blob;f=python-os-client-config.spec;h=1b3a487c6984d7cdbec624c5e9c68eb3859722a3;hb=refs/heads/rpm-master

[Alex Schultz (alex-schultz)]

Adding tech-debt label since we pinned to an older version, https://review.rdoproject.org/r/#/c/12876

[John Trowbridge (trown)]

I think we also need https://review.rdoproject.org/r/12887 to actually get the package to rebuild.

[Rafael Folco (rafaelfolco)]

Per comments in [1] we should remove pinning when os-client-config works with new openstacksdk-12.0, WIP in [2]

[1] https://review.rdoproject.org/r/#/c/12876
[2] https://review.openstack.org/#/c/549307/

[Alex Schultz (alex-schultz)]

This was resolved during the rocky timeframe.