neutron fails to work with pecan-1.3.2

Bug #1754978 reported by Matthew Thode
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Global Requirements
Fix Released
Undecided
Matthew Thode
Zun
Fix Released
Undecided
hongbin
neutron
Fix Released
Undecided
Isaku Yamahata

Bug Description

Requirements would like to update this package but can't (it is currently at version 1.2).

Miguel Lavalle (minsel)
Changed in neutron:
assignee: nobody → Miguel Lavalle (minsel)
Revision history for this message
Matthew Thode (prometheanfire) wrote :

https://review.openstack.org/555891 should be used for peacan only changes

Revision history for this message
Brian Haley (brian-haley) wrote :

https://review.openstack.org/#/c/555891/ should give us enough info to try and get neutron fixed.

Changed in neutron:
assignee: Miguel Lavalle (minsel) → Isaku Yamahata (yamahata)
status: New → In Progress
Revision history for this message
Isaku Yamahata (yamahata) wrote :
Changed in neutron:
assignee: Isaku Yamahata (yamahata) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Isaku Yamahata (yamahata)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/561825
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0063aa33c65def9245730754ab2dc2f1b09b76e0
Submitter: Zuul
Branch: master

commit 0063aa33c65def9245730754ab2dc2f1b09b76e0
Author: Isaku Yamahata <email address hidden>
Date: Mon Apr 16 23:05:53 2018 -0700

    pecan.jsonify v1.3 adjustment

    From pecan v1.3, pecan.jsonify uses json.Encoder unconditionally so that
    jsonifying mock fails.
    Pecan v1.2 uses simplejson.Encoder as encoder which accidentally encodes
    MagicMock as {} due to check of '_asdict' attributes.
    Since pecan.jsonify uses __json__ magic method when it's defined,
    add __json__ method to mocks to return {} as json encode.

    Closes-bug: #1754978
    Change-Id: Iac955a7de2a1b66b5b56a73f5cc8a4e75150f82e

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.0.0b1

This issue was fixed in the openstack/neutron 13.0.0.0b1 development milestone.

Changed in openstack-requirements:
status: New → Fix Released
assignee: nobody → Matthew Thode (prometheanfire)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zun (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562925

Changed in zun:
assignee: nobody → hongbin (hongbin034)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zun (master)

Reviewed: https://review.openstack.org/562925
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=fa8ccc766f2266c39a1a610a26706b295debe7d4
Submitter: Zuul
Branch: master

commit fa8ccc766f2266c39a1a610a26706b295debe7d4
Author: Hongbin Lu <email address hidden>
Date: Fri Apr 20 03:52:04 2018 +0000

    Fix unit test failure with pecan 1.3

    Pecan has been updated to 1.3 [1] which failed the unit test.
    The failure is due to the deserialization of mock object
    (see https://review.openstack.org/#/c/561825/ for details) but
    the controller should return None instead of a mock object.

    [1] https://review.openstack.org/#/c/555891/
    [2] https://review.openstack.org/#/c/561825/

    Change-Id: I6823d833df7aa363fe00b30189ff3024dc4181cd
    Closes-Bug: #1754978

Changed in zun:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zun 2.0.0

This issue was fixed in the openstack/zun 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.