qbrowse: (internally handled) traceback if revno=""

Bug #175487 reported by Kuno Meyer
2
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Medium
Lukáš Lalinský

Bug Description

1. "bzr qbrowse"
2. clear the "revision" field, press ShowRevision
3. see console output:

Traceback (most recent call last):
  File "C:/Documents and Settings/xkm/Application Data/bazaar/2.0/plugins\qbzr\browse.py", line 184, in reload_tree
    revspec = RevisionSpec.from_string(unicode(self.revision_edit.text()))
  File "bzrlib\revisionspec.pyc", line 181, in from_string
bzrlib.errors.NoSuchRevisionSpec: No namespace registered for string: u''

Possible improvements (just variants):
- provide a MessageBox-Feedback that the operation failed
- or: disply "Show revision" grayed as long as the revision number is not valid
- or: treat Revno="" as an alias for the latest revision

in addition:
- make "Show Revision" the default button when editing the revno filed, thus pressing <RETURN> should work

Revision history for this message
Lukáš Lalinský (luks) wrote :

It actualy already does the first option, but only for invalid revision specifiers. I didn't realize it can raise also NoSuchRevisionSpec. I'll add that and aliasing "" to the latest revision.

Lukáš Lalinský (luks)
Changed in qbzr:
assignee: nobody → luks
importance: Undecided → Medium
milestone: none → 0.8.1
status: New → Fix Committed
Lukáš Lalinský (luks)
Changed in qbzr:
milestone: 0.8.1 → 0.9.0
Lukáš Lalinský (luks)
Changed in qbzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.