nova metadata_workers configured in wrong section

[Junien F]

Hi,

mitaka cloud on xenial running 17.11 charms. I haven't touched nova-compute's worker-multiplier, so it has its default value. nova.conf looks like this :

# mitaka
###############################################################################
# [ WARNING ]
# Configuration file maintained by Juju. Local changes may be overwritten.
###############################################################################
[DEFAULT]
[... irrelevant stuff ...]
default_availability_zone = nova
[neutron]
url = http://1.2.3.4:9696
auth_url = http://1.2.3.4:35357
auth_type = password
project_domain_name = default
user_domain_name = default
project_name = services
username = nova
password = password
signing_dir =
metadata_workers = 120
[keystone_authtoken]
[... some more irrelevant stuff ...]

As you can see, the metadata_workers is in the [neutron] section. However, when I start the nova-compute service, here's what it logs :

$ grep metadata_workers /var/log/syslog
Mar 9 10:53:56 a nova-compute[258440]: 2018-03-09 10:53:56.034 258440 DEBUG oslo_service.service [req-77bf5f6e-f2af-435e-939c-c43c703b778b - - - - -] metadata_workers = None log_opt_values /usr/lib/python2.7/dist-packages/oslo_config/cfg.py:2517

So it's failing to parse the number, presumably because it's in the wrong section. If I move "metadata_workers = 120" to the [DEFAULT] section, then nova-compute properly logs "metadata_workers = 120 log_opt_values"

The nova.conf template likely needs fixing. Other OpenStack version may be impacted.

PS : I'm not even sure this number is relevant for nova-compute.

Thanks

[James Page (james-page)]

metadata_workers has context in DVR based deployments where the neutron and nova metadata agents are run on all compute hosts - so in a 'normal' deployment this has no side effect.

[Xav Paice (xavpaice)]

see https://review.openstack.org/#/c/605821/

[Ryan Beisner (1chb1n)]

Track the changes @ https://review.openstack.org/#/q/topic:bug/1754660+(status:open+OR+status:merged)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605821
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=3ddb9980c9027f660b41fabd4de8caf9290ea064
Submitter: Zuul
Branch: master

commit 3ddb9980c9027f660b41fabd4de8caf9290ea064
Author: Drew Freiberger <email address hidden>
Date: Thu Sep 27 12:38:51 2018 -0500

    Move "metadata_workers" to [DEFAULT] in nova.conf

    The option metadata_workers sets the number of nova-api-metadata service
    processes that are spawned when a cloud is running neutron with DVR
    enabled. This configuration option must be present in the [DEFAULT]
    secton of nova.conf per compute config-options references

    Change-Id: Ia42aea5fcc54eca6d8febb9d9ccb064f9517786a
    Closes-Bug: #1754660