5.0: Granular Routing policy. None of the new from conditions work when attached to the SI

[Shashikiran H]

Version: 5.0
Picked up the latest build.

Topo:
10.204.217.7 cfgm control ui openstack
10.204.216.68 cfgm control
10.204.216.72 cfgm control
10.204.217.16 vrouter
10.204.217.17 vrouter

left-vn --- si1(ecmp, in-network) --- si2(ecmp, nat) --- right-vn

If I attach a routing policy with interface, interface static or service interface, to the SI instead of the VN, none of these new "from" conditions work. For interface-static I expect the static route that SI originates to match, which doesn't happen. For service-interface, I expect the SI ip to match which also does not happen. If this case is not supported, it should be removed from config/atleast documented.
<iq>
 <routing-policy-entries>
  <term>
   <term-match-condition>
    <protocol>interface</protocol>
    <community></community>
    <community-match-all>false</community-match-all>
   </term-match-condition>
   <term-action-list>
    <update>
     <as-path>
      <expand />
     </as-path>
     <community>
      <add>
       <community>64512:55555</community>
      </add>
      <remove />
      <set />
     </community>
     <local-pref>0</local-pref>
     <med>0</med>
    </update>
    <action></action>
   </term-action-list>
  </term>
 </routing-policy-entries>
</iq>

[Shashikiran H (skiranh)]

Update from Nikhil:
The only tag seen for routes in SI vrf is service-chain. Brings us to 1756498 and 1754263. Since the legacy routing policy had protocol terms as xmpp, bgp, static, service-chain and aggregate and the legacy application of the routing policy was SI vrf,
1. How were the legacy protocol terms supported till now?
2. Will any terms other than service-chain work for a SI?

If this bug won't be supported, then it would mean the only possible protocol that can potentially work on SI is service-chain.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/41277
Submitter: Nikhil Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/41277
Committed: http://github.com/Juniper/contrail-controller/commit/f60969f70697798130ae829d0994bc5eb2cda605
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f60969f70697798130ae829d0994bc5eb2cda605
Author: Nikhil Bansal <email address hidden>
Date: Mon Apr 2 07:47:38 2018 +0530

Subprotocol should be removed while regenerating

Service chains regenerate routes and regenerated routes should not carry
subprotocol from original routes because protocol gets chaned to
Service-Chain. Otherwise routing policies are not applied correctly

Change-Id: I142eebdad5613cdb74d2693ceddf8a1d4b68d369
Closes-Bug: #1754611